From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajBxT-0007ak-MS for qemu-devel@nongnu.org; Thu, 24 Mar 2016 16:34:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajBxQ-0005al-G8 for qemu-devel@nongnu.org; Thu, 24 Mar 2016 16:34:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajBxQ-0005ah-Ar for qemu-devel@nongnu.org; Thu, 24 Mar 2016 16:34:16 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C08B84DE98 for ; Thu, 24 Mar 2016 20:34:14 +0000 (UTC) References: <1458537955-8032-1-git-send-email-jasowang@redhat.com> <1458537955-8032-3-git-send-email-jasowang@redhat.com> From: Eric Blake Message-ID: <56F44F45.7000405@redhat.com> Date: Thu, 24 Mar 2016 14:34:13 -0600 MIME-Version: 1.0 In-Reply-To: <1458537955-8032-3-git-send-email-jasowang@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hu5DQGJ9GMQC49pTR1IqHnwaQumC1Gnd0" Subject: Re: [Qemu-devel] [PATCH 2/2] tap: vhost busy polling support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , mst@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hu5DQGJ9GMQC49pTR1IqHnwaQumC1Gnd0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/20/2016 11:25 PM, Jason Wang wrote: > This patch add the capability of basic vhost net busy polling which is > supported by recent kernel. User could configure the maximum number of > us that could be spent on busy polling through a new property of tap > "vhost_poll_us". >=20 > Signed-off-by: Jason Wang > --- > +++ b/qapi-schema.json > @@ -2532,7 +2532,8 @@ > '*vhostfd': 'str', > '*vhostfds': 'str', > '*vhostforce': 'bool', > - '*queues': 'uint32'} } > + '*queues': 'uint32', > + '*vhost_poll_us': 'uint32'} } Missing documentation. New interfaces should prefer '-' over '_'; but this is an existing interface where we already have 'vnet_hdr', so intra-command consistency makes your naming okay. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hu5DQGJ9GMQC49pTR1IqHnwaQumC1Gnd0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW9E9FAAoJEKeha0olJ0NqjLUH/2m5zkpJqPxTlF3RdbejYWV2 9899MjqnEgpp64KRF6XWw6k2UEQMQrQSroKNL6T7VuJPwGHxcZaw5hlQ+9ZqrIsg LqtHzFbiJTzqqSduMErQtGQEPos/Ru9DP2w2vj1XhCLhWRdNIJZMR4rRdppCiWmw 0Hz916rg27pk0SENAoLAezrHiEBssa37Qti2j6I8YpsB43yzFCzOmz30uJrBD7aT mDnMCqVK/Mn6Oo4w+JMp4C7iY6aUS8R3ToiuMFmTWmW24egbPmD/DpJtGc7w4Yii DiMRUPgI8iL2EzVZhxuL+Y745NdoeBBaGytcZaeosEHczJM9BhdxMx7B2AJU1uk= =bTIu -----END PGP SIGNATURE----- --hu5DQGJ9GMQC49pTR1IqHnwaQumC1Gnd0--