From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajCva-0001dM-AL for qemu-devel@nongnu.org; Thu, 24 Mar 2016 17:36:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajCvV-00039u-M5 for qemu-devel@nongnu.org; Thu, 24 Mar 2016 17:36:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajCvV-00039p-EU for qemu-devel@nongnu.org; Thu, 24 Mar 2016 17:36:21 -0400 References: <1458853245-7363-1-git-send-email-samuel.thibault@ens-lyon.org> From: Eric Blake Message-ID: <56F45DD3.9080103@redhat.com> Date: Thu, 24 Mar 2016 15:36:19 -0600 MIME-Version: 1.0 In-Reply-To: <1458853245-7363-1-git-send-email-samuel.thibault@ens-lyon.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F4rPOBjkn7uBOvUUEENv1rVK39nkK1mjM" Subject: Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, thuth@redhat.com, jasowang@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F4rPOBjkn7uBOvUUEENv1rVK39nkK1mjM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/24/2016 03:00 PM, Samuel Thibault wrote: In the subject line: "Allow to" is not idiomatic English. "Allow" requires either a subject ("Allow someone to disable"), or a gerund ("Allow disabling"). > Make net=3Dnone disable IPv4 and ip6-net=3Dnone disable IPv6, so the us= er can > setup IPv4-only and IPv6-only network environments. This mentions 'net=3Dnone', but I don't see that in the patch below; instead I see a new boolean. >=20 > Signed-off-by: Samuel Thibault > --- > +++ b/qapi-schema.json > @@ -2425,9 +2425,16 @@ > # > # @restrict: #optional isolate the guest from the host > # > +# @ip4: #optional whether to support IPv4, default is to support both = IPv4 and IPv6. > +# > +# @ip6: #optional whether to support IPv6, default is to support both = IPv4 and IPv6. > +# Missing '(since 2.6)' decorations (or 2.7, if this is too late for 2.6). > # @ip: #optional legacy parameter, use net=3D instead > # > -# @net: #optional IP address and optional netmask > +# @net: #optional IP network address that the guest will see, in the > +# form addr[/netmask] (default is 10.0.2.0/24). The netmask is optiona= l, > +# and can be either in the form a.b.c.d or as a number of valid top-mo= st > +# bits. What happens if 'net' is provided but 'ip4' is false? Is that a user err= or? The existing 'InetSocketAddress' QAPI type spells these as 'ipv4' and ipv6'; should we use the same spelling for consistency? > # > # @host: #optional guest-visible address of the host > # > @@ -2443,7 +2450,9 @@ > # @dnssearch: #optional list of DNS suffixes to search, passed as DHCP= option > # to the guest > # > -# @ip6-prefix: #optional IPv6 network prefix (default is fec0::) (sinc= e 2.6) > +# @ip6-prefix: #optional IPv6 network prefix (default is fec0::) (sinc= e > +# 2.6). The network prefix is given in the usual hexadecimal IPv6 > +# address notation. Likeiwse if 'ip6-prefix' is provided but 'ip6' is false? What if both 'ip4' and 'ip6' are false, user error? Was the intent to allow 'ip6-prefix':'none' as the special case for disabling IPv6? At least the new 'ip6' boolean is introspectible; adding a special-case interpretation of an existing field is not. > @item net=3D@var{addr}[/@var{mask}] > -Set IP network address the guest will see. Optionally specify the netm= ask, > -either in the form a.b.c.d or as number of valid top-most bits. Defaul= t is > -10.0.2.0/24. > +Set IP network address the guest will see or 'none'. Default is > +10.0.2.0/24. The netmask is optional, and can be either in the form > +a.b.c.d or as number of valid top-most bits. 'none' disables IPv4 > +completely. HMP can have syntactic sugar; I'm just fine if HMP's net=3Dnone translate= s into QMP's 'ip4':false. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --F4rPOBjkn7uBOvUUEENv1rVK39nkK1mjM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW9F3TAAoJEKeha0olJ0Nqh78H+gJbDAu48R/nmGApxgoDNEbj cMXjerN800cgT86tt/wrtLrm3u5S4ap3Vz0lB/ryAOzbKbsFobH4n+ICPXW+72o9 PMMrmYxKetCkln7qmArwbd0ML3kcMgi41qb4BlibqaPpX+VSxzmEfaqQljwjM8vI YZPbudwalaCsajohf/joUKZiQ0+HqcJT+ZFleWH4lm/wZ17wFSEUU3CzxLbatGpr UyOIo66EoXrydB/RqDWfqfh8+D2SGeVsywp9dfiqfBsQRBfe4TG5Z5s9Fvx9lZvn cizryW3zALxG/8oqZR5Ta12HvHkm1X2ENI+7/ztlz5ivxI1pQtZN/WSFWZLKJRY= =z74N -----END PGP SIGNATURE----- --F4rPOBjkn7uBOvUUEENv1rVK39nkK1mjM--