From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajDbk-0007gC-KH for qemu-devel@nongnu.org; Thu, 24 Mar 2016 18:20:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajDbf-0004KN-UN for qemu-devel@nongnu.org; Thu, 24 Mar 2016 18:20:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajDbf-0004KI-NZ for qemu-devel@nongnu.org; Thu, 24 Mar 2016 18:19:55 -0400 References: <1458857568-24854-1-git-send-email-samuel.thibault@ens-lyon.org> From: Eric Blake Message-ID: <56F46809.8020106@redhat.com> Date: Thu, 24 Mar 2016 16:19:53 -0600 MIME-Version: 1.0 In-Reply-To: <1458857568-24854-1-git-send-email-samuel.thibault@ens-lyon.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cq4cFR1SE81pNINmsIU41v7rpCKdPQUmK" Subject: Re: [Qemu-devel] [PATCHv2] slirp: Allow disabling IPv4 or IPv6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, thuth@redhat.com, jasowang@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Cq4cFR1SE81pNINmsIU41v7rpCKdPQUmK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/24/2016 04:12 PM, Samuel Thibault wrote: > Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and > IPv6-only network environments. >=20 > Signed-off-by: Samuel Thibault Please mention in the commit message that you are renaming recently-added members, and therefore this MUST be done in 2.6 before we bake in the old naming, as part of your commit... >=20 > --- >=20 > Changes since previous versions: >=20 > - Introduce boolean options ipv4 and ipv6 instead of net=3Dnone and > ip6-net=3Dnone. > - Rename ipv6 options to ipv6-foo instead of ip6-foo, to make it cohere= nt > with the new ipv6 option (itself coherent with the other ipv6 options= ) =2E..rather than just a parenthetical note that gets lost during 'git am'= =2E In fact, I'd probably split it into two patches: one to rename existing s/ip6-/ipv6-/ members, and the other to add new boolean members. > +++ b/qapi-schema.json > @@ -2425,9 +2425,18 @@ > # > # @restrict: #optional isolate the guest from the host > # > +# @ipv4: #optional whether to support IPv4, default is to support both= > +# IPv4 and IPv6 (since 2.6) The last part is long; maybe: =2E.., default true for enabled (since 2.6) > +# > +# @ipv6: #optional whether to support IPv6, default is to support both= > +# IPv4 and IPv6 (since 2.6) and again. > +# > # @ip: #optional legacy parameter, use net=3D instead > # > -# @net: #optional IP address and optional netmask > +# @net: #optional IP network address that the guest will see, in the > +# form addr[/netmask] (default is 10.0.2.0/24). The netmask is optiona= l, > +# and can be either in the form a.b.c.d or as a number of valid top-mo= st > +# bits. Many QAPI commands do hanging indents, as in: # @net: #optional IP network address that the guest will see, in the # form addr[/netmask] (default is 10.0.2.0/24). The netmask is # optional, and can ... so that it is easier to spot the next member's documentation. But I don't think it is a strict requirement. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Cq4cFR1SE81pNINmsIU41v7rpCKdPQUmK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW9GgJAAoJEKeha0olJ0NqLnAH/3EqwpFc/BKeGWziGi6ne/jV 0/G+9jr/VByDgK4sYf3xAhCEzpa9ml3roNaUieq5FU8Gpu7ySYYSFYJu112vD5qv pHhdtXX06i/cfehz76y9h7vNLhO/ExYbevqPEruRUDf56AJIwYUZZKe1J3VjT0gU X8CG/BOIcvHBa8rrK9m10/qAUiZdrQ5vAtiqwn1936gJHuEIHk/sG9Ujwz9Bixwc nwvOD11FcAlOETQ9FeB0yBiThOIz5aceMhtMnZhWZL9uwspIU8HrCRMQPkdXMn48 1+B+Lg6xIbh8ESuX5Pmaq9UT/7uiGHyZuq6XE92q+8C96bruGCPVXvJcOU4CEig= =g46U -----END PGP SIGNATURE----- --Cq4cFR1SE81pNINmsIU41v7rpCKdPQUmK--