From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajt4e-0006nX-E3 for qemu-devel@nongnu.org; Sat, 26 Mar 2016 14:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajt4d-0006hh-IA for qemu-devel@nongnu.org; Sat, 26 Mar 2016 14:36:36 -0400 References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-9-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56F6D6A9.50700@redhat.com> Date: Sat, 26 Mar 2016 19:36:25 +0100 MIME-Version: 1.0 In-Reply-To: <1458325289-17848-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q0oTW0MNiO0RAoqwGonlTXk1prqwDuSnH" Subject: Re: [Qemu-devel] [PATCH 08/20] block: Always set writeback mode in blk_new_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q0oTW0MNiO0RAoqwGonlTXk1prqwDuSnH Content-Type: multipart/mixed; boundary="7KFGA3F1mivvNV5pnBjBTHKTVGBbC4kuj" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <56F6D6A9.50700@redhat.com> Subject: Re: [PATCH 08/20] block: Always set writeback mode in blk_new_open() References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1458325289-17848-9-git-send-email-kwolf@redhat.com> --7KFGA3F1mivvNV5pnBjBTHKTVGBbC4kuj Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 18.03.2016 19:21, Kevin Wolf wrote: > All callers of blk_new_open() either don't rely on the WCE bit set afte= r > blk_new_open() because they explicitly set it anyway, or they pass > BDRV_O_CACHE_WB unconditionally. >=20 > This patch changes blk_new_open() so that it always enables writeback > mode and asserts that BDRV_O_CACHE_WB is clear. For those callers that > used to pass BDRV_O_CACHE_WB unconditionally, the flag is removed now. >=20 > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 4 ++++ > block/parallels.c | 3 +-- > block/qcow.c | 3 +-- > block/qcow2.c | 9 +++------ > block/qed.c | 3 +-- > block/sheepdog.c | 5 ++--- > block/vdi.c | 3 +-- > block/vhdx.c | 3 +-- > block/vmdk.c | 8 +++----- > block/vpc.c | 3 +-- > blockdev.c | 1 + > 11 files changed, 19 insertions(+), 26 deletions(-) Reviewed-by: Max Reitz --7KFGA3F1mivvNV5pnBjBTHKTVGBbC4kuj-- --Q0oTW0MNiO0RAoqwGonlTXk1prqwDuSnH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW9tapAAoJEDuxQgLoOKyt+bEIAKj9q1E3ZDKL50RlDHQFOMsf HpLpED9UdAp/8v67zkmz8MRIPxWFy/4AfpdI71QJs3l4uvJkfGUC/r7mjv1m9BPT etl0s4PF9i93gArlQOuYTTKHC3PPipQEd9dDhf4zUWHC7ehE8qA8I4y7jsdhG2nQ fHZvRP7bHkLx9QI6qN+kDiDMS8UKOf4t8yaqhChARF0PhCTHbKP1Xz6O2Iasj909 1EB8JrRfoZyF6NBxj8vJMJ/dERnto3PU/vhAg+A3T7DquKlBrt3SqsvNTmt+emFO Xhf2lF97oDOJexrUkbdaWRGA7MI1/b7G6dxs+VT97pDi7FNh0qmYMDgWLP1Y5dA= =el9J -----END PGP SIGNATURE----- --Q0oTW0MNiO0RAoqwGonlTXk1prqwDuSnH--