From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajtET-0000c5-MW for qemu-devel@nongnu.org; Sat, 26 Mar 2016 14:46:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajtES-0000BQ-V8 for qemu-devel@nongnu.org; Sat, 26 Mar 2016 14:46:45 -0400 References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-10-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56F6D90C.1040201@redhat.com> Date: Sat, 26 Mar 2016 19:46:36 +0100 MIME-Version: 1.0 In-Reply-To: <1458325289-17848-10-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EsT2KLGEQ9tNNmUeiAd0BXdeRpRE0g9Os" Subject: Re: [Qemu-devel] [PATCH 09/20] block: Handle flush error in bdrv_pwrite_sync() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EsT2KLGEQ9tNNmUeiAd0BXdeRpRE0g9Os Content-Type: multipart/mixed; boundary="4LLFQIHqtCV5nCturH6X9dtmghcnEWSFa" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <56F6D90C.1040201@redhat.com> Subject: Re: [PATCH 09/20] block: Handle flush error in bdrv_pwrite_sync() References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1458325289-17848-10-git-send-email-kwolf@redhat.com> --4LLFQIHqtCV5nCturH6X9dtmghcnEWSFa Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 18.03.2016 19:21, Kevin Wolf wrote: > We don't want to silently ignore a flush error. >=20 > Also, there is little point in avoiding the flush for writethrough mode= s > and once WCE is moved to the BB layer, we definitely need the flush her= e > because bdrv_pwrite() won't involve one any more. >=20 > Signed-off-by: Kevin Wolf > --- > block/io.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz --4LLFQIHqtCV5nCturH6X9dtmghcnEWSFa-- --EsT2KLGEQ9tNNmUeiAd0BXdeRpRE0g9Os Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW9tkMAAoJEDuxQgLoOKytFmcH/29rsSq1r54GlYmilq2/A1mC Rk92FIOrh/nYRFs+Pg8FjLMeIj6k7dV0sqEF6f1OQ3Y3alkX1sJG2fio6cPknbOL G3S368SL/6kfPEAT7BOaMT4ySReyRsV73WVCA/pCAVATpAFe9kJDYE0WsxVZ825y mdn4SxleggaSMgi0sx5pvmXM7uv88e95XIthtD4IdyKcGT6aKtsdGjopIqwjznYF M5kgj1fFy5sCkMXvGmP6CXRETLdnyzI8ord66NvaWCHdfEa0SOAsdQFQHs14pLF7 Af277yoa02CqQY2xldF84rYaiHw/WCf0UmL1ERgpDuzcagWGaU8ZWdyzwCmlEkA= =glgG -----END PGP SIGNATURE----- --EsT2KLGEQ9tNNmUeiAd0BXdeRpRE0g9Os--