From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajv6u-0005fS-LP for qemu-devel@nongnu.org; Sat, 26 Mar 2016 16:47:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajv6t-0005M4-Qo for qemu-devel@nongnu.org; Sat, 26 Mar 2016 16:47:04 -0400 References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-15-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56F6F540.1030003@redhat.com> Date: Sat, 26 Mar 2016 21:46:56 +0100 MIME-Version: 1.0 In-Reply-To: <1458325289-17848-15-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R4cw2QrftXU7vA9VGXTf7SbExIWCISoIQ" Subject: Re: [Qemu-devel] [PATCH 14/20] nbd: Support BDRV_REQ_FUA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R4cw2QrftXU7vA9VGXTf7SbExIWCISoIQ Content-Type: multipart/mixed; boundary="nc60xRG2VAs4NQxeHfQO4LxqQQeT1ep5f" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <56F6F540.1030003@redhat.com> Subject: Re: [PATCH 14/20] nbd: Support BDRV_REQ_FUA References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1458325289-17848-15-git-send-email-kwolf@redhat.com> --nc60xRG2VAs4NQxeHfQO4LxqQQeT1ep5f Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 18.03.2016 19:21, Kevin Wolf wrote: > The NBD server already used to send a FUA flag when the writethrough > mode was set. This code was a remnant from the times where protocol > drivers actually had to implement writethrough modes. Since nowadays th= e > block layer sends flushes in writethrough mode and non-root nodes are > always writeback, this was mostly dead code - only mostly because if NB= D > was configured to be used without a format, we sent _both_ FUA and an > explicit flush afterwards, which makes the code not technically dead, > but useless overhead. >=20 > This patch changes the code so that the block layer's FUA flag is > recognised and translated into a NBD FUA flag. The additional flush is > avoided now. >=20 > Signed-off-by: Kevin Wolf > --- > block/nbd-client.c | 13 +++++++------ > block/nbd-client.h | 2 +- > block/nbd.c | 26 +++++++++++++++++++++----- > 3 files changed, 29 insertions(+), 12 deletions(-) Looks good, but I have the same issue as with patch 13. Max --nc60xRG2VAs4NQxeHfQO4LxqQQeT1ep5f-- --R4cw2QrftXU7vA9VGXTf7SbExIWCISoIQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW9vVAAAoJEDuxQgLoOKyti+8H/1BMCXExoDDHhvHyTK9waj8i ILTrLE3tJ1CergGhcOTaZSOymjwJz7zb5ANU/M4xLLfN2m3VO5XjhsflST0/8XYq WYCqgl5BHMisoFr2ZE2iejPmhfz7o8uQKw5ocw+/gKuWcLG+m0GVf/yhF5DZV9ss +BgsPzzlLa0A0sEAg2AYrod2sl8AdyvIxV5hEJ8hKXtZPw/GCBTAUANFMu7aHaQI xzEAdKfZS2i+ehDskApw3+bF6lgMbJxbOeteH3Drt7Ybi1FYeqjFVzpJoulhl5cZ AMpwVsSQadE6vWQ9HFlN97AxG4HO+JG+5yyqpdxP0tQ5aoyACl0qsp9umBo3oLk= =vdwf -----END PGP SIGNATURE----- --R4cw2QrftXU7vA9VGXTf7SbExIWCISoIQ--