From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajvid-0008Pl-VL for qemu-devel@nongnu.org; Sat, 26 Mar 2016 17:26:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajvid-0004nD-5r for qemu-devel@nongnu.org; Sat, 26 Mar 2016 17:26:03 -0400 References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-21-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56F6FE63.8090803@redhat.com> Date: Sat, 26 Mar 2016 22:25:55 +0100 MIME-Version: 1.0 In-Reply-To: <1458325289-17848-21-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Mmjh5VxnDJDoGBwIOdel3FHeOb6NDtKQ8" Subject: Re: [Qemu-devel] [PATCH 20/20] block: Remove bdrv_(set_)enable_write_cache() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Mmjh5VxnDJDoGBwIOdel3FHeOb6NDtKQ8 Content-Type: multipart/mixed; boundary="LlTRCMkpo2NkIRtqqIe88Dw6DtsD6jFx8" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <56F6FE63.8090803@redhat.com> Subject: Re: [PATCH 20/20] block: Remove bdrv_(set_)enable_write_cache() References: <1458325289-17848-1-git-send-email-kwolf@redhat.com> <1458325289-17848-21-git-send-email-kwolf@redhat.com> In-Reply-To: <1458325289-17848-21-git-send-email-kwolf@redhat.com> --LlTRCMkpo2NkIRtqqIe88Dw6DtsD6jFx8 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 18.03.2016 19:21, Kevin Wolf wrote: > The only remaining users were block jobs (mirror and backup) which > unconditionally enabled WCE on the BlockBackend of the target image. As= > these block jobs don't go through BlockBackend for their I/O requests, > they aren't affected by this setting anyway but always get a writeback > mode, so that call can be removed. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 16 ---------------- > block/backup.c | 1 - > block/mirror.c | 1 - > include/block/block.h | 2 -- > 4 files changed, 20 deletions(-) Reviewed-by: Max Reitz --LlTRCMkpo2NkIRtqqIe88Dw6DtsD6jFx8-- --Mmjh5VxnDJDoGBwIOdel3FHeOb6NDtKQ8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW9v5kAAoJEDuxQgLoOKytFCMH/1R8yo/gdCbR0YgqVZpBTNwc tNIaI+/qm9rpLP1l/fjegEFi9vpGt4wXgg2WoXcc8sIwqOvc9ExUsZaP1gjLawsH rfvJbHCgXLR9lPwYZ+Zl9wLIrE/rJfKPy+zY0keLmx5npRQyYxI7NB2nkW1o2j6g DWoVeI0eL4yaj2L4gWtoXxmWiNtHBTcRCJiYVLvxzthU/b7uujVjAcm9UYZqJkCV lFrqp2Wno5GGRH+X84RGSj1RU5EwUvNQ/9jRqrP3eIIJKha/SyFv0lkDo0XsOERI V6HTcDOORQHzQ8XWR97pQ7xfSH8zo7SUQOEDZjoO1bowtetpvTdSUXLp7jKnJ8g= =A865 -----END PGP SIGNATURE----- --Mmjh5VxnDJDoGBwIOdel3FHeOb6NDtKQ8--