From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akXU5-0006dn-TY for qemu-devel@nongnu.org; Mon, 28 Mar 2016 09:45:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akXU1-0005Ov-OA for qemu-devel@nongnu.org; Mon, 28 Mar 2016 09:45:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akXU1-0005Oq-DV for qemu-devel@nongnu.org; Mon, 28 Mar 2016 09:45:29 -0400 References: <1459161798-32120-1-git-send-email-den@openvz.org> <1459161798-32120-4-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <56F93577.5000008@redhat.com> Date: Mon, 28 Mar 2016 07:45:27 -0600 MIME-Version: 1.0 In-Reply-To: <1459161798-32120-4-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lAvbWcjDPNTsecnoVesnppLQB1VEIn4wA" Subject: Re: [Qemu-devel] [PATCH 3/3] NBD proto: add "Command flags" section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , nbd-general@lists.sourceforge.net, qemu-devel@nongnu.org Cc: Wouter Verhelst , Pavel Borzenkov , Alex Bligh This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lAvbWcjDPNTsecnoVesnppLQB1VEIn4wA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/28/2016 04:43 AM, Denis V. Lunev wrote: > From: Pavel Borzenkov >=20 > Add separate "Command flags" section to make it clear which flags are > currently defined by the protocol. >=20 > Signed-off-by: Pavel Borzenkov > Reviewed-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Wouter Verhelst > CC: Eric Blake > CC: Alex Bligh > --- > doc/proto.md | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/doc/proto.md b/doc/proto.md > index 036d6d9..662f741 100644 > --- a/doc/proto.md > +++ b/doc/proto.md > @@ -485,6 +485,16 @@ The following request types exist: > Currently one such message is known: `NBD_CMD_CACHE`, with type se= t to > 5, implemented by xnbd. > =20 > +#### Command flags > + > +This field of 16 bits is sent by the client with every request and pro= vides > +additional information to the server to execute the command. Refer to > +aforementioned "Request types" section for information about the flags= Maybe: s/aforementioned "Request types" section/the "Request types" section abov= e/ > +supported by particular commands. > + > +- bit 0, `NBD_CMD_FLAG_FUA`; should be set to 1 if the client requires= > + "Force Unit Access" mode of operation Trailing dot? Should you also mention which command(s) it is valid with? (NBD_CMD_WRITE for now, until other extension commands are added) It might also be worth mentioning that the flag should not be sent unless export flags included NBD_FLAG_SEND_FUA. > + > #### Error values > =20 > The error values are used for the error field in the reply message. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lAvbWcjDPNTsecnoVesnppLQB1VEIn4wA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW+TV3AAoJEKeha0olJ0NqYpUH/21NIiJD9WZR1UUqD5EjJBBB rxTVeMwJI/ot1zb7E6OJUkAl7kSWcx8VHc3IilNoMJIZeQKh8SivrQijeYi9CwSR Isf2FQOW5UKzSBMt5wTtfFnXgy8sTYNOTtd9tRLZcio1i7jobsA94aryl//NyfPh 7iyEAmYlXeJ2ONlNIrMiAe9D7KLjoz3VyrmoiRi35jDwX7czIV+W7sDovUVLfjXq HjA5eIQzTJLI0z5RsPDuCqZCEHGU/kfvA0i0X1ygbD8/mXqb+b4vJqWSWewxKNso Gg0pScSL0UZlGae/JxU7bXuW2wN+9OLOrVkDhsckXuBroI+w3+ku+/X7O98GrhM= =a4cq -----END PGP SIGNATURE----- --lAvbWcjDPNTsecnoVesnppLQB1VEIn4wA--