From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akqJN-0001ud-59 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 05:51:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akqJJ-0005v6-3I for qemu-devel@nongnu.org; Tue, 29 Mar 2016 05:51:45 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akqJI-0005uN-S0 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 05:51:41 -0400 Received: by mail-wm0-x242.google.com with SMTP id 20so3607357wmh.3 for ; Tue, 29 Mar 2016 02:51:40 -0700 (PDT) Sender: Paolo Bonzini References: <1458768723-89242-1-git-send-email-dingel@linux.vnet.ibm.com> <56F3D0EE.4050000@redhat.com> <20160329112953.6198e0ac@BR9TG4T3.de.ibm.com> From: Paolo Bonzini Message-ID: <56FA502A.70202@redhat.com> Date: Tue, 29 Mar 2016 11:51:38 +0200 MIME-Version: 1.0 In-Reply-To: <20160329112953.6198e0ac@BR9TG4T3.de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dominik Dingel Cc: Halil Pasic , Richard Henderson , qemu-devel@nongnu.org, Peter Crosthwaite On 29/03/2016 11:29, Dominik Dingel wrote: >> > Why is this part necessary? On x86 you can have 1 megabyte of RAM, >> > but QEMU_VMALLOC_ALIGN is 2MB. > You are right, I changed this to keep the change consistent and thought > the use case of x86 guests with 1 MB RAM might be a little bit obscure. > > Will change this, and keep the page_size check here, and resend a new version > in the next days. Thanks, this is obviously okay for hard freeze so take your time. Paolo