From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akqqg-0000u6-PJ for qemu-devel@nongnu.org; Tue, 29 Mar 2016 06:26:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akqqb-0007bg-Jk for qemu-devel@nongnu.org; Tue, 29 Mar 2016 06:26:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akqqb-0007bY-C8 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 06:26:05 -0400 References: <1458742562-30624-1-git-send-email-den@openvz.org> <1458742562-30624-3-git-send-email-den@openvz.org> <20160323175834.GC2467@grep.be> <56F3D5C7.9070007@redhat.com> <56F406E7.4010207@redhat.com> <56F408D6.2020002@redhat.com> <20160324155319.GK2870@grep.be> <56F4101D.7030603@redhat.com> <20160324160747.GF4310@noname.redhat.com> <20160324164747.GA2902@grep.be> <20160329093835.GB4600@noname.redhat.com> From: Paolo Bonzini Message-ID: <56FA5834.4090702@redhat.com> Date: Tue, 29 Mar 2016 12:25:56 +0200 MIME-Version: 1.0 In-Reply-To: <20160329093835.GB4600@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vHqmjPWIm91oN8vJxJx9k1ahEbhAf27Ts" Subject: Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Wouter Verhelst Cc: nbd-general@lists.sourceforge.net, "Denis V. Lunev" , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vHqmjPWIm91oN8vJxJx9k1ahEbhAf27Ts Content-Type: multipart/mixed; boundary="0rqJo4s3jqGTUQUok15JhoRUit7KoUOi3" From: Paolo Bonzini To: Kevin Wolf , Wouter Verhelst Cc: Eric Blake , nbd-general@lists.sourceforge.net, qemu-devel@nongnu.org, Stefan Hajnoczi , "Denis V. Lunev" Message-ID: <56FA5834.4090702@redhat.com> Subject: Re: [Nbd] [Qemu-devel] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension References: <1458742562-30624-1-git-send-email-den@openvz.org> <1458742562-30624-3-git-send-email-den@openvz.org> <20160323175834.GC2467@grep.be> <56F3D5C7.9070007@redhat.com> <56F406E7.4010207@redhat.com> <56F408D6.2020002@redhat.com> <20160324155319.GK2870@grep.be> <56F4101D.7030603@redhat.com> <20160324160747.GF4310@noname.redhat.com> <20160324164747.GA2902@grep.be> <20160329093835.GB4600@noname.redhat.com> In-Reply-To: <20160329093835.GB4600@noname.redhat.com> --0rqJo4s3jqGTUQUok15JhoRUit7KoUOi3 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 29/03/2016 11:38, Kevin Wolf wrote: > > > How about NBD_STATE_HOLE? > >=20 > > Both will work, although I like NBD_STATE_TRIM slightly better becaus= e > > it indeed nicely references NBD_CMD_TRIM. >=20 > I just thought that "trim" sounds more like an action than a status, an= d > while the reason for a hole to exist can be a previous TRIM command, > another option is that it's an area in an image that just has never bee= n > written to. In that case "trim" would be a misnomer. I agree with Kevin. My preference is still on NBD_STATE_ALLOCATED, but NBD_STATE_HOLE is a fine name as well. Paolo --0rqJo4s3jqGTUQUok15JhoRUit7KoUOi3-- --vHqmjPWIm91oN8vJxJx9k1ahEbhAf27Ts Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+lg0AAoJEL/70l94x66DI4kH/j0nBUYG8U0GxcFT61eQBBGg URma/D6zqO7N4YVyFxIjtTzo2jyv6mQ7GmpK69DR85scnlwdJtbhoFDhq/CtONbv odz61M3FWCF1Ye1FRp7Xs4BA7ff5ev/N4e4wTCJDq/AIVgbFq6O1jdRjRXkV/F0E aczBDVa80f7UtqspaKuAu/T9sgDm7zDeZME9MaQl+p3jAptCqjb3iegVepjIPz0M E3hIZOZi6LkSjWdzEgnQPSuABAgyf6uVPJZPC8+tJUx29TkUcSg93CzYB/Pl4W1A htwkjJQsEJPxOQEWXFAcTMZQucgVkIWtyDw4Mv12OlJHxIg0k3MdJ+0IxkGphC0= =ymCw -----END PGP SIGNATURE----- --vHqmjPWIm91oN8vJxJx9k1ahEbhAf27Ts--