From: Paolo Bonzini <pbonzini@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: arei.gonglei@huawei.com, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] memory: fix segv on qemu_ram_free(block=0x0)
Date: Tue, 29 Mar 2016 13:27:19 +0200 [thread overview]
Message-ID: <56FA6697.20403@redhat.com> (raw)
In-Reply-To: <1459250451-29984-1-git-send-email-marcandre.lureau@redhat.com>
On 29/03/2016 13:20, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Since f1060c55bf1377b4, the pointer is directly passed to
> qemu_ram_free(). However, on initialization failure, it may be called
> with a NULL pointer. Return immediately in this case.
>
> This fixes a SEGV when memory initialization failed, for example
> permission denied on open backing store /dev/hugepages, with -object
> memory-backend-file,mem-path=/dev/hugepages.
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x00005555556e67e7 in qemu_ram_free (block=0x0) at /home/elmarco/src/qemu/exec.c:1775
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Looks good, thanks! I'll push it during hard freeze.
Paolo
prev parent reply other threads:[~2016-03-29 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 11:20 [Qemu-devel] [PATCH] memory: fix segv on qemu_ram_free(block=0x0) marcandre.lureau
2016-03-29 11:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA6697.20403@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=famz@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).