From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akro1-0001tq-NK for qemu-devel@nongnu.org; Tue, 29 Mar 2016 07:27:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akrnx-00062f-LR for qemu-devel@nongnu.org; Tue, 29 Mar 2016 07:27:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akrnx-00062S-GZ for qemu-devel@nongnu.org; Tue, 29 Mar 2016 07:27:25 -0400 References: <1459250451-29984-1-git-send-email-marcandre.lureau@redhat.com> From: Paolo Bonzini Message-ID: <56FA6697.20403@redhat.com> Date: Tue, 29 Mar 2016 13:27:19 +0200 MIME-Version: 1.0 In-Reply-To: <1459250451-29984-1-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] memory: fix segv on qemu_ram_free(block=0x0) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, famz@redhat.com On 29/03/2016 13:20, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Since f1060c55bf1377b4, the pointer is directly passed to > qemu_ram_free(). However, on initialization failure, it may be called > with a NULL pointer. Return immediately in this case. >=20 > This fixes a SEGV when memory initialization failed, for example > permission denied on open backing store /dev/hugepages, with -object > memory-backend-file,mem-path=3D/dev/hugepages. >=20 > Program received signal SIGSEGV, Segmentation fault. > 0x00005555556e67e7 in qemu_ram_free (block=3D0x0) at /home/elmarco/src/= qemu/exec.c:1775 >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau Looks good, thanks! I'll push it during hard freeze. Paolo