From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aku0f-0003Y8-6a for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:48:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aku0a-0004vp-AZ for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:48:41 -0400 References: <1459258257-17767-1-git-send-email-kwolf@redhat.com> <1459258257-17767-18-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56FA87A7.9060405@redhat.com> Date: Tue, 29 Mar 2016 15:48:23 +0200 MIME-Version: 1.0 In-Reply-To: <1459258257-17767-18-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kNvgjfC0VR2Qof7bUpmnUIo0NSV9KEv8F" Subject: Re: [Qemu-devel] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kNvgjfC0VR2Qof7bUpmnUIo0NSV9KEv8F Content-Type: multipart/mixed; boundary="GEKRVhhmc8SL3P1TtkjIGQJqtnBI8uXpq" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <56FA87A7.9060405@redhat.com> Subject: Re: [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f() References: <1459258257-17767-1-git-send-email-kwolf@redhat.com> <1459258257-17767-18-git-send-email-kwolf@redhat.com> In-Reply-To: <1459258257-17767-18-git-send-email-kwolf@redhat.com> --GEKRVhhmc8SL3P1TtkjIGQJqtnBI8uXpq Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 29.03.2016 15:30, Kevin Wolf wrote: > We must forbid changing the WCE flag in bdrv_reopen() in the same patch= , > as otherwise the behaviour would change so that the flag takes > precedence over the explicitly specified option. >=20 > The correct value of the WCE flag depends on the BlockBackend user (e.g= =2E > guest device) and isn't a decision that the QMP client makes, so this > change is what we want. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 18 ++++++------------ > qemu-io-cmds.c | 14 +++++++++++++- > tests/qemu-iotests/142 | 2 +- > tests/qemu-iotests/142.out | 2 +- > 4 files changed, 21 insertions(+), 15 deletions(-) Reviewed-by: Max Reitz For some weird reason I thought that blk_enable_write_cache() always returned true here. Which is not true, of course. Max --GEKRVhhmc8SL3P1TtkjIGQJqtnBI8uXpq-- --kNvgjfC0VR2Qof7bUpmnUIo0NSV9KEv8F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+oeoAAoJEDuxQgLoOKytQVkH/2ldDiBG9gtZIEwh9ZiK6OAs jG8zqIKL7PmL9och9b0deu+s08r5STZ/fdPL+zI9MF5Jke10uY6t4EblpDAxJnfX 3q04X7Opi2w/v/RX5yS7TAODq1R1jg6CGdF9JOpDxRxXY3R51QMieNjQ4kgevAI0 7/iye27NBfLTB8BXZ0Yhs+BvOvaidf0ykJHUnkho7C9VZD1oKoEGqBLYJWc9e099 U8Jjjyhn6Zvqp51ssDD9HdlWW2ME2n9qXoK2m8tY/HJqYG+Appkn4MsN/JqcbmUD KWBZsM5RN7NALpxisdUvK/T1zKBGx1m4oGfbMFmsot40OglmNBxW4KcF9Tsl6aw= =K011 -----END PGP SIGNATURE----- --kNvgjfC0VR2Qof7bUpmnUIo0NSV9KEv8F--