From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aku27-0005iw-L2 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:50:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aku22-0005J7-18 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:50:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aku21-0005Iq-RZ for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:50:05 -0400 References: <1458836125-73613-1-git-send-email-cornelia.huck@de.ibm.com> <56F8AB31.1090107@linux.vnet.ibm.com> <56F973E7.5070704@redhat.com> <56FA476D.1030107@linux.vnet.ibm.com> <20160329134546.7226abac.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <56FA8808.8050101@redhat.com> Date: Tue, 29 Mar 2016 15:50:00 +0200 MIME-Version: 1.0 In-Reply-To: <20160329134546.7226abac.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , tu bo Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 29/03/2016 13:45, Cornelia Huck wrote: > > > Hi Tu Bo, > > > > > > please always include the assertion patch at > > > https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in > > > your tests. Can you include the backtrace from all threads with that patch? > > > > > thanks for your reminder about the assertion patch. Here is the > > backtrace with qemu master + assertion patch + "[PATCH 0/6] virtio: > > refactor host notifiers", > > FWIW, I've been running this in a reboot loop for the last 2 1/2 hours. > Could you perhaps share your command line? >>From code inspection, the following is also necessary or at least a good idea: diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 6fb29e3..7fa8477 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -258,7 +258,7 @@ void virtio_blk_data_plane_stop(VirtIOBlockDataPlane *s) aio_context_acquire(s->ctx); /* Stop notifications for new requests from guest */ - virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, false, false); + virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, true, false); /* Drain and switch bs back to the QEMU main loop */ blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context());