From: Chen Gang <chengang@emindsoft.com.cn>
To: Laurent Vivier <laurent@vivier.eu>,
rth@twiddle.net, peter.maydell@linaro.org, cmetcalf@ezchip.com
Cc: walt@tilera.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user/signal.c: Generate opcode data for restorer in setup_rt_frame
Date: Tue, 29 Mar 2016 21:53:44 +0800 [thread overview]
Message-ID: <56FA88E8.1060206@emindsoft.com.cn> (raw)
In-Reply-To: <56F9B6E1.7080004@emindsoft.com.cn>
On 3/29/16 06:57, Chen Gang wrote:
> On 3/29/16 06:17, Laurent Vivier wrote:
>>
>> The address of retcode in host and guest can differ.
>> You need something like:
>>
>> restorer = (unsigned long)(frame_addr + offsetof(struct
>> target_rt_sigframe, retcode));
>>
>> I've experienced this on sh4 (see commit 2a0fa68)
>>
>
> OK, thanks. What you said above sounds reasonable to me. :-)
>
> I shall send patch v2 for it (although tilegx is a pure 64-bit target,
> with this patch, I guess, tilegx target should still run correctly under
> 32-bit host).
>
> By the way, it looks that s390x and microblaze targets also have the
> same issue.
It looks the alpha target may also need consider about retcode, for "r26
= frame_addr" in setup_rt_frame().
Thanks.
--
Chen Gang (陈刚)
Managing Natural Environments is the Duty of Human Beings.
prev parent reply other threads:[~2016-03-29 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 21:51 [Qemu-devel] [PATCH] linux-user/signal.c: Generate opcode data for restorer in setup_rt_frame chengang
2016-03-27 9:44 ` Chen Gang
2016-03-28 22:17 ` Laurent Vivier
2016-03-28 22:57 ` Chen Gang
2016-03-29 13:53 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA88E8.1060206@emindsoft.com.cn \
--to=chengang@emindsoft.com.cn \
--cc=cmetcalf@ezchip.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).