From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1akuUp-0005NP-2r
	for qemu-devel@nongnu.org; Tue, 29 Mar 2016 10:19:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1akuUk-0006kG-3w
	for qemu-devel@nongnu.org; Tue, 29 Mar 2016 10:19:51 -0400
Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36706)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1akuUj-0006k8-U0
	for qemu-devel@nongnu.org; Tue, 29 Mar 2016 10:19:46 -0400
Received: by mail-wm0-x242.google.com with SMTP id 20so5774105wmh.3
	for <qemu-devel@nongnu.org>; Tue, 29 Mar 2016 07:19:45 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1459258923-10319-1-git-send-email-mst@redhat.com>
	<1459258923-10319-2-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56FA8EFF.8060805@redhat.com>
Date: Tue, 29 Mar 2016 16:19:43 +0200
MIME-Version: 1.0
In-Reply-To: <1459258923-10319-2-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio: add aio handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>



On 29/03/2016 15:42, Michael S. Tsirkin wrote:
> +void virtio_queue_notify_aio_vq(VirtQueue *vq)
> +{
> +    if (vq->vring.desc && vq->handle_aio_output) {
> +        VirtIODevice *vdev = vq->vdev;
> +
> +        trace_virtio_queue_notify(vdev, vq - vdev->vq, vq);
> +        vq->handle_aio_output(vdev, vq);
> +    }
> +}
> +

This can be static, and virtio_queue_notify_vq probably should too.

Paolo