From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akviy-00011b-0O for qemu-devel@nongnu.org; Tue, 29 Mar 2016 11:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akvis-000742-30 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 11:38:31 -0400 References: <1457578181-27111-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1457578181-27111-3-git-send-email-xiecl.fnst@cn.fujitsu.com> <56E653E0.9030808@cn.fujitsu.com> <56EA06E0.7000409@cn.fujitsu.com> <56EA7C62.3090000@cn.fujitsu.com> <20160317094831.GA2504@work-vm> <56EA7F39.9060504@cn.fujitsu.com> From: Max Reitz Message-ID: <56FAA168.9090304@redhat.com> Date: Tue, 29 Mar 2016 17:38:16 +0200 MIME-Version: 1.0 In-Reply-To: <56EA7F39.9060504@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j4GrAHhQLaUQWgpA8te3esKphfewaUPiM" Subject: Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , "Dr. David Alan Gilbert" Cc: Kevin Wolf , Changlong Xie , Alberto Garcia , zhanghailiang , qemu block , Jiang Yunhong , Dong Eddie , qemu devel , Markus Armbruster , Gonglei , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j4GrAHhQLaUQWgpA8te3esKphfewaUPiM Content-Type: multipart/mixed; boundary="7KEc15ESMspN3IGX6ToED9a8AQf3nTfHI" From: Max Reitz To: Wen Congyang , "Dr. David Alan Gilbert" Cc: Alberto Garcia , Changlong Xie , qemu devel , Eric Blake , Kevin Wolf , Stefan Hajnoczi , Markus Armbruster , Dong Eddie , Jiang Yunhong , qemu block , zhanghailiang , Gonglei Message-ID: <56FAA168.9090304@redhat.com> Subject: Re: [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child() References: <1457578181-27111-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1457578181-27111-3-git-send-email-xiecl.fnst@cn.fujitsu.com> <56E653E0.9030808@cn.fujitsu.com> <56EA06E0.7000409@cn.fujitsu.com> <56EA7C62.3090000@cn.fujitsu.com> <20160317094831.GA2504@work-vm> <56EA7F39.9060504@cn.fujitsu.com> In-Reply-To: <56EA7F39.9060504@cn.fujitsu.com> --7KEc15ESMspN3IGX6ToED9a8AQf3nTfHI Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 17.03.2016 10:56, Wen Congyang wrote: > On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: [...] >> The children.0 notation is really confusing in the way that Berto >> describes; I hit this a couple of months ago and it really doesn't >> make sense. >=20 > Do you mean: read from children.1 first, and then read from children.0 = in > fifo mode? Yes, the behavior is very strange. So is this intended or is it not? In http://lists.nongnu.org/archive/html/qemu-block/2016-03/msg00526.html you said that it is. I myself would indeed say it is very strange. If I were a user, I would not expect this behavior. And as I developer, I think that how a BDS's child is used by its parent should solely depend on its role (e.g. whether it is "children.0" or "children.1"). Max --7KEc15ESMspN3IGX6ToED9a8AQf3nTfHI-- --j4GrAHhQLaUQWgpA8te3esKphfewaUPiM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+qFoAAoJEDuxQgLoOKytvmQH/3kfl/L511yzBObH52xrMe0h zWaxG+ipi55vjyeP53wdwvKxLL4FODNujRBEI8iiIcE/7+qqJHsXOhbhgIyKFMBQ GNsYC8zwFKSdXCPQuyhAmgySN86Yhhe5azFH4hiRKNL0ictCS5JEMJ4bSvV97dqn VQ44zgWMWbJ/AKsYlsuiZUxoP5dLQ+FMzyuZsK/Euz7/u5PDD+Mzq9L7cffarda4 mjd5qhpChHSDmqLRGkI2TRgoyLW/DJXl+XPDErKo3RP6G9Ga3CYXSTjfhHwV9sDE e4UdAAnKslM0mNc9EiHP57CbEfFmzcLGxXaITj1ug5qT16Q10y7Dfeei9zEn/f8= =IBcv -----END PGP SIGNATURE----- --j4GrAHhQLaUQWgpA8te3esKphfewaUPiM--