From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akw0l-0003oj-1h for qemu-devel@nongnu.org; Tue, 29 Mar 2016 11:56:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akw0h-0004Tt-19 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 11:56:54 -0400 References: <1458846438-28573-1-git-send-email-mreitz@redhat.com> <20160329155118.GF4600@noname.redhat.com> From: Max Reitz Message-ID: <56FAA5BB.8030801@redhat.com> Date: Tue, 29 Mar 2016 17:56:43 +0200 MIME-Version: 1.0 In-Reply-To: <20160329155118.GF4600@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oOglB99Vo01qiOfheIeJ3pUCUnlFe9tuK" Subject: Re: [Qemu-devel] [RFC for-2.7 0/1] block/qapi: Add query-block-node-tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oOglB99Vo01qiOfheIeJ3pUCUnlFe9tuK Content-Type: multipart/mixed; boundary="pD0P2id4QUEsAVtd3thTtsOcHk6koXvFI" From: Max Reitz To: Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Wen Congyang , Eric Blake , Markus Armbruster Message-ID: <56FAA5BB.8030801@redhat.com> Subject: Re: [RFC for-2.7 0/1] block/qapi: Add query-block-node-tree References: <1458846438-28573-1-git-send-email-mreitz@redhat.com> <20160329155118.GF4600@noname.redhat.com> In-Reply-To: <20160329155118.GF4600@noname.redhat.com> --pD0P2id4QUEsAVtd3thTtsOcHk6koXvFI Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 29.03.2016 17:51, Kevin Wolf wrote: > Am 24.03.2016 um 20:07 hat Max Reitz geschrieben: >> As I responded to: >> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.htm= l >> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05680.htm= l >> >> I think a general solution for querying the block node tree would be >> nice (I don't think we actually have one). The single patch in this >> series implements such a command. >> >> However, this is an RFC because I'm not sure whether we really want th= is >> and thus I didn't want to write the necessary tests for something we m= ay >> be going to discard anyway. >=20 > I think we do want to have a way to query the tree structure in QMP. Th= e > part that I'm so sure about is whether we want a recursive command or > one that just covers the children of a single node. If we want the > latter, just adding a children field (which maps role names to node > names) to query-block might be enough. Sounds fine in principle to me, but I'd like to add that I think we may want to have a new command for querying a specific BDS. You don't get much choice which nodes you query with query-block, and query-named-block-nodes seems a bit bloated to me by now... About the "mapping role names to node names" though; I suppose you mean like { "file": "file-node", "backing": "other-qcow2-node" }. I'd have loved to do that, but I couldn't imagine a way to represent that in the QAPI schema. Max --pD0P2id4QUEsAVtd3thTtsOcHk6koXvFI-- --oOglB99Vo01qiOfheIeJ3pUCUnlFe9tuK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+qW7AAoJEDuxQgLoOKytxQQIAJXsgwgZRkNK/6Xa2i0GxAju rxMsqmkKo83tcFBpb/De3BDdDO93ye32PsLxhPB97PjhMf6dfiuSOZi3ki62h5t6 wiN3HXypMCj+8rZNPWFdh0LJT1+Zqk1/VqEvnMd+XoIhOhBIGu++UF5pvxwyoMZN eBju6BPR3IA1DtcE0QK4jGeMCPv4hR92Z7GJylmtmZWNvvZGvhtvKx4WVqyIV+SP 8v12CG0+3jMcdLZl9QjpuQr4GAwuw6kHyVQUep6IGut3ycHKg3aG1kJkn6KhbnD2 YY95HDZzQj744tsMRDf4ch82l0LqjXHAzXOJ3G+QERhZh3kXHUBunNCBCS4Ji2s= =AXoV -----END PGP SIGNATURE----- --oOglB99Vo01qiOfheIeJ3pUCUnlFe9tuK--