From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwER-00083k-7W for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akwEM-00014z-V8 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:11:03 -0400 References: <1458846438-28573-1-git-send-email-mreitz@redhat.com> <20160329155118.GF4600@noname.redhat.com> <56FAA5BB.8030801@redhat.com> <20160329160920.GG4600@noname.redhat.com> From: Max Reitz Message-ID: <56FAA906.6030305@redhat.com> Date: Tue, 29 Mar 2016 18:10:46 +0200 MIME-Version: 1.0 In-Reply-To: <20160329160920.GG4600@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FfHlrNXXS08TIjAnMV8twnoxm6nOmeVNB" Subject: Re: [Qemu-devel] [RFC for-2.7 0/1] block/qapi: Add query-block-node-tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FfHlrNXXS08TIjAnMV8twnoxm6nOmeVNB Content-Type: multipart/mixed; boundary="0Jt4s2Cl6waeGsBT5w7vl3AIWwhFAJ6FE" From: Max Reitz To: Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Wen Congyang , Eric Blake , Markus Armbruster Message-ID: <56FAA906.6030305@redhat.com> Subject: Re: [RFC for-2.7 0/1] block/qapi: Add query-block-node-tree References: <1458846438-28573-1-git-send-email-mreitz@redhat.com> <20160329155118.GF4600@noname.redhat.com> <56FAA5BB.8030801@redhat.com> <20160329160920.GG4600@noname.redhat.com> In-Reply-To: <20160329160920.GG4600@noname.redhat.com> --0Jt4s2Cl6waeGsBT5w7vl3AIWwhFAJ6FE Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 29.03.2016 18:09, Kevin Wolf wrote: > Am 29.03.2016 um 17:56 hat Max Reitz geschrieben: >> On 29.03.2016 17:51, Kevin Wolf wrote: >>> Am 24.03.2016 um 20:07 hat Max Reitz geschrieben: >>>> As I responded to: >>>> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.h= tml >>>> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05680.h= tml >>>> >>>> I think a general solution for querying the block node tree would be= >>>> nice (I don't think we actually have one). The single patch in this >>>> series implements such a command. >>>> >>>> However, this is an RFC because I'm not sure whether we really want = this >>>> and thus I didn't want to write the necessary tests for something we= may >>>> be going to discard anyway. >>> >>> I think we do want to have a way to query the tree structure in QMP. = The >>> part that I'm so sure about is whether we want a recursive command or= >>> one that just covers the children of a single node. If we want the >>> latter, just adding a children field (which maps role names to node >>> names) to query-block might be enough. >> >> Sounds fine in principle to me, but I'd like to add that I think we ma= y >> want to have a new command for querying a specific BDS. You don't get >> much choice which nodes you query with query-block, and >> query-named-block-nodes seems a bit bloated to me by now... >=20 > Maybe we need to start over with a new query-block-node command that > takes a node name (or BB name as an alias for its root node) and return= s > information only about that node. That is, it adds node-name support > compared to query-block, but it removes the recursive crap for backing > files that we added there. Yes, sounds good to me. >> About the "mapping role names to node names" though; I suppose you mea= n >> like { "file": "file-node", "backing": "other-qcow2-node" }. I'd have >> loved to do that, but I couldn't imagine a way to represent that in th= e >> QAPI schema. >=20 > Eric and Markus will tell us, but if nothing else helps: >=20 > { 'children': 'any' } But that's cheating! :-) Max --0Jt4s2Cl6waeGsBT5w7vl3AIWwhFAJ6FE-- --FfHlrNXXS08TIjAnMV8twnoxm6nOmeVNB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+qkGAAoJEDuxQgLoOKytcqoH/A7VGmkmVIHHT7fDNITmmvzT SFMScOqEJNVyJIHUh4FOcFmZSXxYpJATmhb7B3aP9bBMcliAUpCLlvTZXaQbRjBn sgGeOvKCBGKe9QUHvk0B1z1iwl250Ag4PRSsiXZdoMb9712zPpso2el4LaDn6po8 kejgupRcJIXTN2SCZjNp3dbR1C3227ZtNWEtv3y+smH3mAuo0rUdCocoFVf6dp8m j+/CSKxU3QFLo6KUkbXpcbCsByAJvcRgvlG8HY1nqQ1K6gzB3DU8Yjik6cLgZiRV P09TpsGKGDCriUj8WIP5rekCkczLOvXaeIgS/GZI8o2ezbZcYhQpSRHC5tkNL2Y= =PSNA -----END PGP SIGNATURE----- --FfHlrNXXS08TIjAnMV8twnoxm6nOmeVNB--