From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwUf-0000RT-JV for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akwUc-0006Mr-Cs for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:27:49 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:43611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwUc-0006MM-25 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:27:46 -0400 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 29 Mar 2016 17:27:44 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8A198219005C for ; Tue, 29 Mar 2016 17:27:23 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2TGRhhm61341786 for ; Tue, 29 Mar 2016 16:27:43 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2TFRi6d019427 for ; Tue, 29 Mar 2016 09:27:44 -0600 References: <1458836125-73613-1-git-send-email-cornelia.huck@de.ibm.com> <56F8AB31.1090107@linux.vnet.ibm.com> <56F973E7.5070704@redhat.com> <56FA476D.1030107@linux.vnet.ibm.com> <20160329134546.7226abac.cornelia.huck@de.ibm.com> <56FA8808.8050101@redhat.com> From: Christian Borntraeger Message-ID: <56FAACFD.90101@de.ibm.com> Date: Tue, 29 Mar 2016 18:27:41 +0200 MIME-Version: 1.0 In-Reply-To: <56FA8808.8050101@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Cornelia Huck , tu bo Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 03/29/2016 03:50 PM, Paolo Bonzini wrote: > > > On 29/03/2016 13:45, Cornelia Huck wrote: >>>> Hi Tu Bo, >>>> >>>> please always include the assertion patch at >>>> https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in >>>> your tests. Can you include the backtrace from all threads with that patch? >>>> >>> thanks for your reminder about the assertion patch. Here is the >>> backtrace with qemu master + assertion patch + "[PATCH 0/6] virtio: >>> refactor host notifiers", >> >> FWIW, I've been running this in a reboot loop for the last 2 1/2 hours. >> Could you perhaps share your command line? > > From code inspection, the following is also necessary or at least a > good idea: > > diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c > index 6fb29e3..7fa8477 100644 > --- a/hw/block/dataplane/virtio-blk.c > +++ b/hw/block/dataplane/virtio-blk.c > @@ -258,7 +258,7 @@ void virtio_blk_data_plane_stop(VirtIOBlockDataPlane *s) > aio_context_acquire(s->ctx); > > /* Stop notifications for new requests from guest */ > - virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, false, false); > + virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, true, false); > > /* Drain and switch bs back to the QEMU main loop */ > blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context()); > Right. Tu Bo, you seem to have the best testcase for this. Does your setup runs fine with this on top? CHristian