From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akxgK-00005N-9t for qemu-devel@nongnu.org; Tue, 29 Mar 2016 13:44:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akxgJ-0007VK-HV for qemu-devel@nongnu.org; Tue, 29 Mar 2016 13:43:56 -0400 References: <1458675397-24956-1-git-send-email-kwolf@redhat.com> <1458675397-24956-3-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56FABED3.205@redhat.com> Date: Tue, 29 Mar 2016 19:43:47 +0200 MIME-Version: 1.0 In-Reply-To: <1458675397-24956-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oAais6kqFehNPet19NnbRNXvD5cRnefw4" Subject: Re: [Qemu-devel] [PATCH 2/9] block: User BdrvChild callback for device name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oAais6kqFehNPet19NnbRNXvD5cRnefw4 Content-Type: multipart/mixed; boundary="pb7DnvQDfu8scJfjRnPXwhfGk6U34RdQr" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <56FABED3.205@redhat.com> Subject: Re: [PATCH 2/9] block: User BdrvChild callback for device name References: <1458675397-24956-1-git-send-email-kwolf@redhat.com> <1458675397-24956-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1458675397-24956-3-git-send-email-kwolf@redhat.com> --pb7DnvQDfu8scJfjRnPXwhfGk6U34RdQr Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 22.03.2016 20:36, Kevin Wolf wrote: > In order to get rid of bs->blk for bdrv_get_device_name() and > bdrv_get_device_or_node_name(), ask all parents for their name and > simply pick the first one. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 22 ++++++++++++++++++++-- > block/block-backend.c | 6 ++++++ > include/block/block_int.h | 1 + > 3 files changed, 27 insertions(+), 2 deletions(-) [...] > diff --git a/include/block/block_int.h b/include/block/block_int.h > index f60cb7c..195abe8 100644 > --- a/include/block/block_int.h > +++ b/include/block/block_int.h > @@ -358,6 +358,7 @@ struct BdrvChildRole { > =20 > void (*change_media)(BdrvChild *child, bool load); > void (*resize)(BdrvChild *child); > + const char* (*get_name)(BdrvChild *child); > =20 > bool (*drain_queue)(BdrvChild *child); > }; I wouldn't mind an explanation there what this is supposed to be used for. From the name alone I'd expect a parent BDS to return its node name.= Reviewed-by: Max Reitz --pb7DnvQDfu8scJfjRnPXwhfGk6U34RdQr-- --oAais6kqFehNPet19NnbRNXvD5cRnefw4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+r7TAAoJEDuxQgLoOKyt9LQIAKlHyLuwEvq5gESp/dYyDy8l JjAl3ICr/gzYu4115Np9m1RfJwgK9gzwjm1GwsTPWIHpfqqQDFpRY9mkAlk5Ase5 lrKfXM5sQUSLH49VRuUluppdtUzfb+cgaYfywgAinYV0QUyM/WdCshgjHkb5bXHv f2g5zFJnRRmv5/iwQKTZmm+6bqlYXPwenSN+fxyLdpJ0nGuLdEkmVMoFRASmyV6k 4QT4AYbiI1WTxhr5XxaOlGIPrEL8q+5LIsLRBfV6x/zB8xoa+Vg6Iq3JVpB7YOFm 5OWDty9iLwqFw46CoHfCqzYtUehorFh4/kfDtbiUqzWagGKvwwH1o8OnAYqcSjo= =H3z2 -----END PGP SIGNATURE----- --oAais6kqFehNPet19NnbRNXvD5cRnefw4--