From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al4go-0002po-R8 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 21:12:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1al4gl-0006XT-LS for qemu-devel@nongnu.org; Tue, 29 Mar 2016 21:12:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al4gl-0006XJ-Fq for qemu-devel@nongnu.org; Tue, 29 Mar 2016 21:12:51 -0400 References: <1458872009-13342-1-git-send-email-jasowang@redhat.com> <1458872009-13342-3-git-send-email-jasowang@redhat.com> <20160328020257.GH28183@pxdev.xzpeter.org> From: Jason Wang Message-ID: <56FB280E.6030008@redhat.com> Date: Wed, 30 Mar 2016 09:12:46 +0800 MIME-Version: 1.0 In-Reply-To: <20160328020257.GH28183@pxdev.xzpeter.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/8] intel_iommu: name vtd address space with devfn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: Eduardo Habkost , mst@redhat.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, pbonzini@redhat.com, Richard Henderson On 03/28/2016 10:02 AM, Peter Xu wrote: > On Fri, Mar 25, 2016 at 10:13:23AM +0800, Jason Wang wrote: >> To avoid duplicated name and ease debugging. >> >> Cc: Michael S. Tsirkin >> Cc: Paolo Bonzini >> Cc: Richard Henderson >> Cc: Eduardo Habkost >> Signed-off-by: Jason Wang >> --- >> hw/i386/intel_iommu.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c >> index 347718f..d647b42 100644 >> --- a/hw/i386/intel_iommu.c >> +++ b/hw/i386/intel_iommu.c >> @@ -1901,6 +1901,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn) >> uintptr_t key = (uintptr_t)bus; >> VTDBus *vtd_bus = g_hash_table_lookup(s->vtd_as_by_busptr, &key); >> VTDAddressSpace *vtd_dev_as; >> + char name[128]; >> >> if (!vtd_bus) { >> /* No corresponding free() */ >> @@ -1913,6 +1914,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn) >> vtd_dev_as = vtd_bus->dev_as[devfn]; >> >> if (!vtd_dev_as) { >> + sprintf(name, "intel_iommu_devfn_%d", devfn); > It's safe here, but would snprintf() look better? Not sure, we're sure that name is large enough here. > >> vtd_bus->dev_as[devfn] = vtd_dev_as = g_malloc0(sizeof(VTDAddressSpace)); >> >> vtd_dev_as->bus = bus; >> @@ -1920,9 +1922,9 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn) >> vtd_dev_as->iommu_state = s; >> vtd_dev_as->context_cache_entry.context_cache_gen = 0; >> memory_region_init_iommu(&vtd_dev_as->iommu, OBJECT(s), >> - &s->iommu_ops, "intel_iommu", UINT64_MAX); >> + &s->iommu_ops, name, UINT64_MAX); >> address_space_init(&vtd_dev_as->as, >> - &vtd_dev_as->iommu, "intel_iommu"); >> + &vtd_dev_as->iommu, name); >> } >> return vtd_dev_as; >> } >> -- >> 2.5.0 >> > Besides the nit-pick: > > Acked-by: Peter Xu >