From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al4oY-00065K-8f for qemu-devel@nongnu.org; Tue, 29 Mar 2016 21:20:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1al4oP-0007mx-Mh for qemu-devel@nongnu.org; Tue, 29 Mar 2016 21:20:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al4oP-0007mR-F2 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 21:20:45 -0400 References: <1458891729-28131-1-git-send-email-jasowang@redhat.com> From: Jason Wang Message-ID: <56FB29E7.7020109@redhat.com> Date: Wed, 30 Mar 2016 09:20:39 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/7] Net patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 03/30/2016 12:39 AM, Peter Maydell wrote: > On 25 March 2016 at 07:42, Jason Wang wrote: >> The following changes since commit b68a80139e37e806f004237e55311ebc421= 51434: >> >> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' in= to staging (2016-03-24 16:24:02 +0000) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to e680f08328f6a05a43963c3e9db1b0cdc701ed9= f: >> >> Revert "e1000: fix hang of win2k12 shutdown with flood ping" (2016-0= 3-25 10:39:43 +0800) >> >> ---------------------------------------------------------------- >> >> - mirror/redirector which could mirror or redirct the traffic between >> netdev and chardev >> - fix e1000 interrupt strom and remove previous hack > Hi. I'm afraid this fails to compile: > > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c: In function > =E2=80=98filter_mirror_setup=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:242:9: > error: implicit declaration of function =E2=80=98error_setg=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > error_setg(errp, "filter filter mirror needs 'outdev' " > ^ > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:242:9: > error: nested extern declaration of =E2=80=98error_setg=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:9: > error: implicit declaration of function =E2=80=98error_set=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, > ^ > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:9: > error: nested extern declaration of =E2=80=98error_set=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:25: > error: =E2=80=98ERROR_CLASS_DEVICE_NOT_FOUND=E2=80=99 undeclared (first= use in this > function) > error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, > ^ > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:249:25: > note: each undeclared identifier is reported only once for each > function it appears in > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c: In function > =E2=80=98filter_redirector_setup=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/net/filter-mirror.c:281:29: > error: =E2=80=98ERROR_CLASS_DEVICE_NOT_FOUND=E2=80=99 undeclared (first= use in this > function) > error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, > ^ > cc1: all warnings being treated as errors > > I think your commit has unfortunately clashed with the > pull from Paolo that I've just applied that makes > changes to our include files. Right, will fix and send V2. Thanks > > thanks > -- PMM >