qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: tu bo <tubo@linux.vnet.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, tubo@cn.ibm.com
Subject: Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races
Date: Wed, 30 Mar 2016 09:32:27 +0200	[thread overview]
Message-ID: <56FB810B.3090900@redhat.com> (raw)
In-Reply-To: <56FB4248.2030700@linux.vnet.ibm.com>



On 30/03/2016 05:04, tu bo wrote:
> Hi Christian:
> 
> On 03/30/2016 12:31 AM, Christian Borntraeger wrote:
>> On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote:
>>> This works around races that data plane introduces
>>> simply by exiting immediately if we detect
>>> that dataplane is active.
>>>
>>> It's a small but ugly patch, it's only justification
>>> is that it's minimally intrusive, and that it clearly
>>> has no chance to break non data plane users.
>>>
>>> The idea is to rework it all post 2.6.
>>>
>>> Michael S. Tsirkin (2):
>>>    virtio: add aio handler
>>>    virtio-blk: use aio handler for data plane
>>>
>>>   include/hw/virtio/virtio-blk.h  |  2 ++
>>>   include/hw/virtio/virtio.h      |  4 ++++
>>>   hw/block/dataplane/virtio-blk.c | 13 +++++++++++++
>>>   hw/block/virtio-blk.c           | 28 ++++++++++++++++++----------
>>>   hw/virtio/virtio.c              | 36
>>> ++++++++++++++++++++++++++++++++----
>>>   5 files changed, 69 insertions(+), 14 deletions(-)
>>>
>>
>> This also seems to help on my setup.Tu Bo, would be good if you
>> can double check this patch set as well on your setup?
> 
> With qemu master +  [PATCH 0/2] dataplane: fix start/stop races,
> 
> I did NOT see any crash, result is good in my box. thanks

Great, I will send a revised version of Michael's patches with
virtio-scsi too.

Paolo

      reply	other threads:[~2016-03-30  7:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 13:42 [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races Michael S. Tsirkin
2016-03-29 13:42 ` [Qemu-devel] [PATCH 1/2] virtio: add aio handler Michael S. Tsirkin
2016-03-29 14:19   ` Paolo Bonzini
2016-03-29 13:42 ` [Qemu-devel] [PATCH 2/2] virtio-blk: use aio handler for data plane Michael S. Tsirkin
2016-03-29 13:56   ` Paolo Bonzini
2016-03-29 13:58     ` Michael S. Tsirkin
2016-03-29 13:59       ` Paolo Bonzini
2016-03-29 14:05   ` Paolo Bonzini
2016-03-29 14:09     ` Michael S. Tsirkin
2016-03-29 14:44       ` Paolo Bonzini
2016-03-29 13:43 ` [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races Michael S. Tsirkin
2016-03-29 15:06 ` Cornelia Huck
2016-03-29 16:31 ` Christian Borntraeger
2016-03-30  3:04   ` tu bo
2016-03-30  7:32     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FB810B.3090900@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tubo@cn.ibm.com \
    --cc=tubo@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).