From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alAcH-0000UO-76 for qemu-devel@nongnu.org; Wed, 30 Mar 2016 03:32:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alAcD-0007Br-VN for qemu-devel@nongnu.org; Wed, 30 Mar 2016 03:32:37 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:32869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alAcD-0007Bn-Nj for qemu-devel@nongnu.org; Wed, 30 Mar 2016 03:32:33 -0400 Received: by mail-wm0-x241.google.com with SMTP id i204so10271147wmd.0 for ; Wed, 30 Mar 2016 00:32:33 -0700 (PDT) Sender: Paolo Bonzini References: <1459258923-10319-1-git-send-email-mst@redhat.com> <56FAADE8.2070708@de.ibm.com> <56FB4248.2030700@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <56FB810B.3090900@redhat.com> Date: Wed, 30 Mar 2016 09:32:27 +0200 MIME-Version: 1.0 In-Reply-To: <56FB4248.2030700@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tu bo , Christian Borntraeger , "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Cornelia Huck , tubo@cn.ibm.com On 30/03/2016 05:04, tu bo wrote: > Hi Christian: > > On 03/30/2016 12:31 AM, Christian Borntraeger wrote: >> On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote: >>> This works around races that data plane introduces >>> simply by exiting immediately if we detect >>> that dataplane is active. >>> >>> It's a small but ugly patch, it's only justification >>> is that it's minimally intrusive, and that it clearly >>> has no chance to break non data plane users. >>> >>> The idea is to rework it all post 2.6. >>> >>> Michael S. Tsirkin (2): >>> virtio: add aio handler >>> virtio-blk: use aio handler for data plane >>> >>> include/hw/virtio/virtio-blk.h | 2 ++ >>> include/hw/virtio/virtio.h | 4 ++++ >>> hw/block/dataplane/virtio-blk.c | 13 +++++++++++++ >>> hw/block/virtio-blk.c | 28 ++++++++++++++++++---------- >>> hw/virtio/virtio.c | 36 >>> ++++++++++++++++++++++++++++++++---- >>> 5 files changed, 69 insertions(+), 14 deletions(-) >>> >> >> This also seems to help on my setup.Tu Bo, would be good if you >> can double check this patch set as well on your setup? > > With qemu master + [PATCH 0/2] dataplane: fix start/stop races, > > I did NOT see any crash, result is good in my box. thanks Great, I will send a revised version of Michael's patches with virtio-scsi too. Paolo