From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alBeQ-0000FP-Jk for qemu-devel@nongnu.org; Wed, 30 Mar 2016 04:38:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alBeL-00070p-Kq for qemu-devel@nongnu.org; Wed, 30 Mar 2016 04:38:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alBeL-00070l-FN for qemu-devel@nongnu.org; Wed, 30 Mar 2016 04:38:49 -0400 References: <1459208679-27805-1-git-send-email-samuel.thibault@ens-lyon.org> <1459208679-27805-2-git-send-email-samuel.thibault@ens-lyon.org> From: Thomas Huth Message-ID: <56FB9096.9070102@redhat.com> Date: Wed, 30 Mar 2016 10:38:46 +0200 MIME-Version: 1.0 In-Reply-To: <1459208679-27805-2-git-send-email-samuel.thibault@ens-lyon.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, jasowang@redhat.com, armbru@redhat.com On 29.03.2016 01:44, Samuel Thibault wrote: > Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and > IPv6-only network environments. > > Signed-off-by: Samuel Thibault > > --- > > Changes since previous versions: > > - fix coding style > --- > net/slirp.c | 36 ++++++++++++++++++++++++++++++------ > qapi-schema.json | 8 ++++++++ > qemu-options.hx | 8 ++++++-- > slirp/ip6_icmp.c | 8 ++++++++ > slirp/ip6_input.c | 5 +++++ > slirp/ip_input.c | 4 ++++ > slirp/libslirp.h | 3 ++- > slirp/slirp.c | 10 +++++++++- > slirp/slirp.h | 2 ++ > 9 files changed, 74 insertions(+), 10 deletions(-) > [...] > diff --git a/qemu-options.hx b/qemu-options.hx > index 09162f5..705f162 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1551,8 +1551,9 @@ DEF("smb", HAS_ARG, QEMU_OPTION_smb, "", QEMU_ARCH_ALL) > > DEF("netdev", HAS_ARG, QEMU_OPTION_netdev, > #ifdef CONFIG_SLIRP > - "-netdev user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n" > - " [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n" > + "-netdev user,id=str[,ipv4][,net=addr[/mask]][,host=addr]\n" > + " [,ipv6][,ipv6-net=addr[/int]][,ipv6-host=addr]\n" > + " [,restrict=on|off][,hostname=host][,dhcpstart=addr]\n" > " [,dns=addr][,ipv6-dns=addr][,dnssearch=domain][,tftp=dir]\n" > " [,bootfile=f][,hostfwd=rule][,guestfwd=rule]" Shouldn't that rather be "[,ipv4=on|off]" and "[,ipv6=on|off]" for a boolean value? Apart from that, the patch looks fine to me. Thomas