From: Joscha Benz <jbenz@mailbox.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu
Date: Wed, 30 Mar 2016 12:46:26 +0200 [thread overview]
Message-ID: <56FBAE82.1080203@mailbox.org> (raw)
In-Reply-To: <CAKmqyKPpOLkaUDwPjxyQNoxOd8eY0AzFScsTJ8LA9WRx2bQrJQ@mail.gmail.com>
Hi,
On 29.03.2016 22:23, Alistair Francis wrote:
> On Tue, Mar 29, 2016 at 12:51 PM, <jbenz@mailbox.org> wrote:
>> Signed-off-by: Joscha Benz <jbenz@mailbox.org>
>
> Hello Joscha ,
>
> Thanks for the patch. In future can you please use git send-email to
> send the patches instead of attaching the patch file. You can find
> more information on doing this at:
> http://wiki.qemu.org/Contribute/SubmitAPatch
Of course.
> What are you trying to do here? Why are you trying to apply the Xilinx
> model of the device? This relies on the register API (which you have
> included in your patch) which isn't in mainline QEMU yet, so that part
> can't be accepted just yet. We are working at upstreaming that at the
> moment though.
I was trying to get USB support for that device. That's why i tried to
apply the Xilinx model since it has USB support.
Regards,
Joscha
next prev parent reply other threads:[~2016-03-30 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 19:51 [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu jbenz
2016-03-29 20:23 ` Alistair Francis
2016-03-30 10:46 ` Joscha Benz [this message]
2016-04-01 0:40 ` Alistair Francis
2016-04-04 15:04 ` Joscha Benz
2016-11-11 23:45 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBAE82.1080203@mailbox.org \
--to=jbenz@mailbox.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).