From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58471)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jbenz@mailbox.org>) id 1alDep-0003jB-Ru
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 06:47:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jbenz@mailbox.org>) id 1alDek-0006B4-RV
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 06:47:27 -0400
Received: from mx2.mailbox.org ([80.241.60.215]:38858)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jbenz@mailbox.org>) id 1alDek-0006Ao-I5
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 06:47:22 -0400
Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx2.mailbox.org (Postfix) with ESMTPS id D4198434AE
	for <qemu-devel@nongnu.org>; Wed, 30 Mar 2016 12:47:21 +0200 (CEST)
Received: from smtp1.mailbox.org ([80.241.60.240])
	by gerste.heinlein-support.de (gerste.heinlein-support.de
	[91.198.250.173]) (amavisd-new, port 10030)
	with ESMTP id 2pdjFo-GNbVP for <qemu-devel@nongnu.org>;
	Wed, 30 Mar 2016 12:47:19 +0200 (CEST)
References: <1459281084-13346-1-git-send-email-jbenz@mailbox.org>
	<CAKmqyKPpOLkaUDwPjxyQNoxOd8eY0AzFScsTJ8LA9WRx2bQrJQ@mail.gmail.com>
From: Joscha Benz <jbenz@mailbox.org>
Message-ID: <56FBAE82.1080203@mailbox.org>
Date: Wed, 30 Mar 2016 12:46:26 +0200
MIME-Version: 1.0
In-Reply-To: <CAKmqyKPpOLkaUDwPjxyQNoxOd8eY0AzFScsTJ8LA9WRx2bQrJQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY
 and ULPI viewport from xilinx/qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

On 29.03.2016 22:23, Alistair Francis wrote:
> On Tue, Mar 29, 2016 at 12:51 PM,  <jbenz@mailbox.org> wrote:
>> Signed-off-by: Joscha Benz <jbenz@mailbox.org>
>=20
> Hello Joscha ,
>=20
> Thanks for the patch. In future can you please use git send-email to
> send the patches instead of attaching the patch file. You can find
> more information on doing this at:
> http://wiki.qemu.org/Contribute/SubmitAPatch

Of course.

> What are you trying to do here? Why are you trying to apply the Xilinx
> model of the device? This relies on the register API (which you have
> included in your patch) which isn't in mainline QEMU yet, so that part
> can't be accepted just yet. We are working at upstreaming that at the
> moment though.

I was trying to get USB support for that device. That's why i tried to
apply the Xilinx model since it has USB support.

Regards,

Joscha