From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alGCK-0007a8-4H for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:30:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alGCG-0003be-U1 for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:30:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alGCG-0003bK-PD for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:30:08 -0400 References: <1459342088-24311-1-git-send-email-pbonzini@redhat.com> <1459342088-24311-2-git-send-email-pbonzini@redhat.com> <20160330152355.693aad1c.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <56FBD4DC.5070104@redhat.com> Date: Wed, 30 Mar 2016 15:30:04 +0200 MIME-Version: 1.0 In-Reply-To: <20160330152355.693aad1c.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On 30/03/2016 15:23, Cornelia Huck wrote: > > There is no need to run the handler one last time; the device is bein= g > > reset and it is okay to drop requests that are pending in the virtque= ue. >=20 > What about virtio_blk_save()? Could there be any pending requests in > that case? Those would be processed when dataplane is restarted on the destination side, I think. virtio_queue_set_host_notifier_fd_handler calls virtio_queue_host_notifier_read which connects the host notifier to the I/O thread and calls event_notifier_set to start processing it. Paolo