From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55369)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1alHhz-0004OC-2g
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:07:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1alHhv-0007VT-57
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:06:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44924)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1alHhv-0007V5-0Z
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:06:55 -0400
References: <1459208679-27805-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1459208679-27805-2-git-send-email-samuel.thibault@ens-lyon.org>
	<56FB9096.9070102@redhat.com>
	<20160330150409.GC15708@var.bordeaux.inria.fr>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <56FBEB8B.5030208@redhat.com>
Date: Wed, 30 Mar 2016 17:06:51 +0200
MIME-Version: 1.0
In-Reply-To: <20160330150409.GC15708@var.bordeaux.inria.fr>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: jan.kiszka@siemens.com, jasowang@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On 30.03.2016 17:04, Samuel Thibault wrote:
> Hello,
> 
> Thomas Huth, on Wed 30 Mar 2016 10:38:46 +0200, wrote:
>>> -    "-netdev user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n"
>>> -    "         [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
>>> +    "-netdev user,id=str[,ipv4][,net=addr[/mask]][,host=addr]\n"
>>> +    "         [,ipv6][,ipv6-net=addr[/int]][,ipv6-host=addr]\n"
>>> +    "         [,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
>>>      "         [,dns=addr][,ipv6-dns=addr][,dnssearch=domain][,tftp=dir]\n"
>>>      "         [,bootfile=f][,hostfwd=rule][,guestfwd=rule]"
>>
>> Shouldn't that rather be "[,ipv4=on|off]" and "[,ipv6=on|off]" for a
>> boolean value?
> 
> Well, just like the rest of these ipv4/ipv6 options, they do accept
> =on|off, but it's not documented in the qemu-options.hx file.  Should we
> fix them all?

The "restrict" option is listed with "=on|off" here, that's why I
thought it should be there for "ipv4" and "ipv6", too. Which boolean
options are missing the "=on|off" ?

 Thomas