From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56433)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1alHkE-0008Sq-Bv
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:09:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1alHk9-0008ON-Ax
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:09:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1alHk9-0008OF-4e
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:09:13 -0400
References: <1459342088-24311-1-git-send-email-pbonzini@redhat.com>
	<1459342088-24311-6-git-send-email-pbonzini@redhat.com>
	<20160330165515.7e903720.cornelia.huck@de.ibm.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56FBEC14.1030903@redhat.com>
Date: Wed, 30 Mar 2016 17:09:08 +0200
MIME-Version: 1.0
In-Reply-To: <20160330165515.7e903720.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/9] virtio: add aio handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com



On 30/03/2016 16:55, Cornelia Huck wrote:
>> >      if (assign && set_handler) {
>> >          aio_set_event_notifier(ctx, &vq->host_notifier, true,
>> > -                               virtio_queue_host_notifier_read);
>> > +                               virtio_queue_host_notifier_aio_read);
>> >      } else {
>> >          aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL);
>> >      }
>> >      if (!assign) {
>> >          /* Test and clear notifier before after disabling event,
>> >           * in case poll callback didn't have time to run. */
>> > -        virtio_queue_host_notifier_read(&vq->host_notifier);
>> > +        virtio_queue_host_notifier_aio_read(&vq->host_notifier);
> Is this function ever called with assign==false anymore after patch 1?

Patch 8 provides the answer (which is no :)).

Paolo