From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIGh-00007g-TR for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:42:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alIGe-0001tW-5u for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:42:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIGe-0001tK-0M for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:42:48 -0400 References: <1459342088-24311-1-git-send-email-pbonzini@redhat.com> <1459342088-24311-7-git-send-email-pbonzini@redhat.com> <20160330172556.68f41e2b.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <56FBF3F3.2010400@redhat.com> Date: Wed, 30 Mar 2016 17:42:43 +0200 MIME-Version: 1.0 In-Reply-To: <20160330172556.68f41e2b.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On 30/03/2016 17:25, Cornelia Huck wrote: >> > >> > - /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start >> > - * dataplane here instead of waiting for .set_status(). >> > - */ >> > - if (s->dataplane && !s->dataplane_started) { >> > - virtio_blk_data_plane_start(s->dataplane); >> > - return; >> > - } >> > - >> > assert(atomic_fetch_inc(&s->reentrancy_test) == 0); > Hm, based on wrong branch? > Indeed I had the testing patch in there for, well, testing. I'll repost with improved commit messages and the assertion removed. Paolo