From: Max Reitz <mreitz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests
Date: Wed, 30 Mar 2016 17:51:16 +0200 [thread overview]
Message-ID: <56FBF5F4.4020804@redhat.com> (raw)
In-Reply-To: <1459345997-1610-3-git-send-email-berrange@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 916 bytes --]
On 30.03.2016 15:53, Daniel P. Berrange wrote:
> The LUKS block driver tests will require the ability to specify
> encryption secrets with block devices. This requires using the
> --object argument to qemu-img/qemu-io to create a 'secret'
> object.
>
> When the IMGKEYSECRET env variable is set, it provides the
> password to be associated with a secret called 'keysec0'
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> tests/qemu-iotests/common | 1 +
> tests/qemu-iotests/common.config | 6 ++++++
> tests/qemu-iotests/common.filter | 3 ++-
> tests/qemu-iotests/common.rc | 16 +++++++++++++---
> 4 files changed, 22 insertions(+), 4 deletions(-)
Is there a reason why you didn't implement the same logic in
_qemu_img_wrapper as in _qemu_io_wrapper?
This works, but it appears a bit overcomplicated to me.
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-30 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 13:53 [Qemu-devel] [PATCH v7 0/3] Tests for LUKS driver Daniel P. Berrange
2016-03-30 13:53 ` [Qemu-devel] [PATCH v7 1/3] block: add support for --image-opts in block I/O tests Daniel P. Berrange
2016-03-30 15:44 ` Max Reitz
2016-03-30 15:52 ` Daniel P. Berrange
2016-03-30 13:53 ` [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets " Daniel P. Berrange
2016-03-30 15:51 ` Max Reitz [this message]
2016-03-30 15:53 ` Daniel P. Berrange
2016-03-30 13:53 ` [Qemu-devel] [PATCH v7 3/3] block: enable testing of LUKS driver with " Daniel P. Berrange
2016-03-30 16:03 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBF5F4.4020804@redhat.com \
--to=mreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).