From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIP2-0006xD-GO for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alIP1-0004nc-9h for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:51:28 -0400 References: <1459345997-1610-1-git-send-email-berrange@redhat.com> <1459345997-1610-3-git-send-email-berrange@redhat.com> From: Max Reitz Message-ID: <56FBF5F4.4020804@redhat.com> Date: Wed, 30 Mar 2016 17:51:16 +0200 MIME-Version: 1.0 In-Reply-To: <1459345997-1610-3-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mvklqP1IRQfqXiNmLUr8c3vu92l6N0fgJ" Subject: Re: [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mvklqP1IRQfqXiNmLUr8c3vu92l6N0fgJ Content-Type: multipart/mixed; boundary="uAGA332PK4cUN00ErCAn7TGjdW7t9VJL5" From: Max Reitz To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf Message-ID: <56FBF5F4.4020804@redhat.com> Subject: Re: [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests References: <1459345997-1610-1-git-send-email-berrange@redhat.com> <1459345997-1610-3-git-send-email-berrange@redhat.com> In-Reply-To: <1459345997-1610-3-git-send-email-berrange@redhat.com> --uAGA332PK4cUN00ErCAn7TGjdW7t9VJL5 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 30.03.2016 15:53, Daniel P. Berrange wrote: > The LUKS block driver tests will require the ability to specify > encryption secrets with block devices. This requires using the > --object argument to qemu-img/qemu-io to create a 'secret' > object. >=20 > When the IMGKEYSECRET env variable is set, it provides the > password to be associated with a secret called 'keysec0' >=20 > Signed-off-by: Daniel P. Berrange > --- > tests/qemu-iotests/common | 1 + > tests/qemu-iotests/common.config | 6 ++++++ > tests/qemu-iotests/common.filter | 3 ++- > tests/qemu-iotests/common.rc | 16 +++++++++++++--- > 4 files changed, 22 insertions(+), 4 deletions(-) Is there a reason why you didn't implement the same logic in _qemu_img_wrapper as in _qemu_io_wrapper? This works, but it appears a bit overcomplicated to me. Reviewed-by: Max Reitz --uAGA332PK4cUN00ErCAn7TGjdW7t9VJL5-- --mvklqP1IRQfqXiNmLUr8c3vu92l6N0fgJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+/X1AAoJEDuxQgLoOKytww8H/A83E2VsnwwUD9VMY3s4tcOL vPnFdZK0piMSlp6KZy1yktt3XJnpJtHn/LtOSAXZN0OUy/QRgTnpZCpKAzgajufr 6qkw0Hk/4kos884z4aiP3j4lUTKRPCM/zEYEzD+HFG3YzRuAoprdRVANriYIjOyQ eaCvKOGDsPobow4h4UyLfBUxaO1Uptpcv4uZqNtQCpVlLGJcGLWynwcSDF96WQHo hD2cg3rIYXVTymefKokAikn2FwGeFkA7XSf2nMy6aCdmpJox2YmjfiDvrWZdMsUs hQ5yWUOYd9TUZfGgACqrs9kfCiFGgOJvhFHEZMokdS8V/NNVOhdk1rTqkzUnJSI= =UJcG -----END PGP SIGNATURE----- --mvklqP1IRQfqXiNmLUr8c3vu92l6N0fgJ--