From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIS1-0002du-MR for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:54:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alIS0-0006GF-O8 for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:54:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIS0-0006Fr-Ir for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:54:32 -0400 References: <1459208679-27805-1-git-send-email-samuel.thibault@ens-lyon.org> <1459208679-27805-2-git-send-email-samuel.thibault@ens-lyon.org> <56FB9096.9070102@redhat.com> <20160330150409.GC15708@var.bordeaux.inria.fr> <56FBEB8B.5030208@redhat.com> <20160330151340.GD15708@var.bordeaux.inria.fr> <56FBF0C8.8060300@redhat.com> <20160330153607.GI15708@var.bordeaux.inria.fr> From: Eric Blake Message-ID: <56FBF6B7.2000802@redhat.com> Date: Wed, 30 Mar 2016 09:54:31 -0600 MIME-Version: 1.0 In-Reply-To: <20160330153607.GI15708@var.bordeaux.inria.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BMw7F2qcmorh4unKxmXaU8HDv4TfXNA3R" Subject: Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , Thomas Huth , armbru@redhat.com Cc: jan.kiszka@siemens.com, jasowang@redhat.com, qemu-devel@nongnu.org, Eduardo Habkost This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BMw7F2qcmorh4unKxmXaU8HDv4TfXNA3R Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/30/2016 09:36 AM, Samuel Thibault wrote: > Thomas Huth, on Wed 30 Mar 2016 17:29:12 +0200, wrote: >> On 30.03.2016 17:13, Samuel Thibault wrote: >>> Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: >>>> The "restrict" option is listed with "=3Don|off" here, that's why I >>>> thought it should be there for "ipv4" and "ipv6", too. Which boolean= >>>> options are missing the "=3Don|off" ? >>> >>> All the ipv4 and ipv6 options in the same file. >> >> Ugh, ok, now I see it ... most of these are specified in qemu-options.= hx >> without the "=3Don|off", only for the "-netdev l2tpv3" it is specified= as >> "ipv6=3Don/off" (with slash instead of the pipe character!) ... what a= >> mess... not sure which is the best way to go here, so maybe keep it >> without the "=3Don|off" for now so that it is consistent with most of = the >> other options? >=20 > Eric, Markus, what do you prefer? No strong preference. Libvirt doesn't parse the command line --help output, precisely because (as you've noticed) it is a big inconsistent mess already. Pick one, and that's fine; and it's a bonus if you want to do a followup cleanup for consistency, but I won't lose any sleep if you don't do a followup. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BMw7F2qcmorh4unKxmXaU8HDv4TfXNA3R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW+/a3AAoJEKeha0olJ0NqcMcH/AucmAChCrcdy4A3r0gA2RH1 aVtslp8JeIQvYyTgomnLKzlEI5EV+hCWbEx8lqNBWN/wjxnFsAnxjnD3SGSoCW+x n4lNG4x5L+yMaADZ7SI0WCJ+JDYESDeyAbiAFAx1R/i0YKzUZT8RN54lYZrORa3D oKcN+WZgsVMULaYHtJR1eHE0q/ExHeILZVJI9TkWO4B2dUWfgmEaOM1AuXaLT8A8 0GSsKq2EC8Av7VTvcUfG0TsfftQ+HLRFae/x9duTQ7KMe7bLK212pV9iPFuqNXZq QEtmmf/wzsigh3D9233/FUbF/QYdGM0n0a4vjSwC3gn5udUhHlketndHWwJDGPY= =e7ts -----END PGP SIGNATURE----- --BMw7F2qcmorh4unKxmXaU8HDv4TfXNA3R--