From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alSUs-0006KV-0W for qemu-devel@nongnu.org; Wed, 30 Mar 2016 22:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alSUo-00010f-QZ for qemu-devel@nongnu.org; Wed, 30 Mar 2016 22:38:09 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:60180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alSUo-00010T-Js for qemu-devel@nongnu.org; Wed, 30 Mar 2016 22:38:06 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Mar 2016 20:38:04 -0600 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id A819F19D8045 for ; Wed, 30 Mar 2016 20:25:54 -0600 (MDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2V2c13w33816716 for ; Thu, 31 Mar 2016 02:38:01 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2V2c0HV023761 for ; Wed, 30 Mar 2016 22:38:00 -0400 References: <1458836125-73613-1-git-send-email-cornelia.huck@de.ibm.com> <56F8AB31.1090107@linux.vnet.ibm.com> <56F973E7.5070704@redhat.com> <56FA476D.1030107@linux.vnet.ibm.com> <20160329134546.7226abac.cornelia.huck@de.ibm.com> <56FA8808.8050101@redhat.com> <56FAACFD.90101@de.ibm.com> From: tu bo Message-ID: <56FC8D85.7060608@linux.vnet.ibm.com> Date: Thu, 31 Mar 2016 10:37:57 +0800 MIME-Version: 1.0 In-Reply-To: <56FAACFD.90101@de.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Paolo Bonzini , Cornelia Huck Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com Hi Christian: On 03/30/2016 12:27 AM, Christian Borntraeger wrote: > On 03/29/2016 03:50 PM, Paolo Bonzini wrote: >> >> >> On 29/03/2016 13:45, Cornelia Huck wrote: >>>>> Hi Tu Bo, >>>>> >>>>> please always include the assertion patch at >>>>> https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in >>>>> your tests. Can you include the backtrace from all threads with that patch? >>>>> >>>> thanks for your reminder about the assertion patch. Here is the >>>> backtrace with qemu master + assertion patch + "[PATCH 0/6] virtio: >>>> refactor host notifiers", >>> >>> FWIW, I've been running this in a reboot loop for the last 2 1/2 hours. >>> Could you perhaps share your command line? >> >> From code inspection, the following is also necessary or at least a >> good idea: >> >> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c >> index 6fb29e3..7fa8477 100644 >> --- a/hw/block/dataplane/virtio-blk.c >> +++ b/hw/block/dataplane/virtio-blk.c >> @@ -258,7 +258,7 @@ void virtio_blk_data_plane_stop(VirtIOBlockDataPlane *s) >> aio_context_acquire(s->ctx); >> >> /* Stop notifications for new requests from guest */ >> - virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, false, false); >> + virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, true, false); >> >> /* Drain and switch bs back to the QEMU main loop */ >> blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context()); >> > > Right. Tu Bo, you seem to have the best testcase for this. > Does your setup runs fine with this on top? My test needs at least four scsi disks, which was broken now because of the s38 firmware update. I'll test it when s38 scsi is ready. thx > > CHristian >