From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alVSX-0007p8-Om for qemu-devel@nongnu.org; Thu, 31 Mar 2016 01:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alVSU-00009Y-HI for qemu-devel@nongnu.org; Thu, 31 Mar 2016 01:47:57 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:49114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alVSU-00009F-Ag for qemu-devel@nongnu.org; Thu, 31 Mar 2016 01:47:54 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Mar 2016 23:47:53 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 67B953E40030 for ; Wed, 30 Mar 2016 23:47:51 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2V5lpSd35127308 for ; Wed, 30 Mar 2016 22:47:51 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2V5loGM014884 for ; Wed, 30 Mar 2016 23:47:51 -0600 References: <1458836125-73613-1-git-send-email-cornelia.huck@de.ibm.com> <56F8AB31.1090107@linux.vnet.ibm.com> <56F973E7.5070704@redhat.com> <56FA476D.1030107@linux.vnet.ibm.com> <20160329134546.7226abac.cornelia.huck@de.ibm.com> <56FA8808.8050101@redhat.com> <56FAACFD.90101@de.ibm.com> From: tu bo Message-ID: <56FCBA02.6080304@linux.vnet.ibm.com> Date: Thu, 31 Mar 2016 13:47:46 +0800 MIME-Version: 1.0 In-Reply-To: <56FAACFD.90101@de.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Paolo Bonzini , Cornelia Huck Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com Hi Christian: I got the same crash with qemu master + assertion patch + "[PATCH 0/6] virtio: refactor host notifiers" + Paolo's fix, (gdb) bt #0 blk_aio_read_entry (opaque=0x0) at block/block-backend.c:916 #1 0x000002aa2e8e88fe in coroutine_trampoline (i0=, i1=-1677703696) at util/coroutine-ucontext.c:78 #2 0x000003ffa85d150a in __makecontext_ret () from /lib64/libc.so.6 On 03/30/2016 12:27 AM, Christian Borntraeger wrote: > On 03/29/2016 03:50 PM, Paolo Bonzini wrote: >> >> >> On 29/03/2016 13:45, Cornelia Huck wrote: >>>>> Hi Tu Bo, >>>>> >>>>> please always include the assertion patch at >>>>> https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in >>>>> your tests. Can you include the backtrace from all threads with that patch? >>>>> >>>> thanks for your reminder about the assertion patch. Here is the >>>> backtrace with qemu master + assertion patch + "[PATCH 0/6] virtio: >>>> refactor host notifiers", >>> >>> FWIW, I've been running this in a reboot loop for the last 2 1/2 hours. >>> Could you perhaps share your command line? >> >> From code inspection, the following is also necessary or at least a >> good idea: >> >> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c >> index 6fb29e3..7fa8477 100644 >> --- a/hw/block/dataplane/virtio-blk.c >> +++ b/hw/block/dataplane/virtio-blk.c >> @@ -258,7 +258,7 @@ void virtio_blk_data_plane_stop(VirtIOBlockDataPlane *s) >> aio_context_acquire(s->ctx); >> >> /* Stop notifications for new requests from guest */ >> - virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, false, false); >> + virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, true, false); >> >> /* Drain and switch bs back to the QEMU main loop */ >> blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context()); >> > > Right. Tu Bo, you seem to have the best testcase for this. > Does your setup runs fine with this on top? > > CHristian >