From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alWUt-0002op-Bx for qemu-devel@nongnu.org; Thu, 31 Mar 2016 02:54:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alWUp-0006g0-4p for qemu-devel@nongnu.org; Thu, 31 Mar 2016 02:54:27 -0400 References: <1459357980-29330-1-git-send-email-lvivier@redhat.com> <20160331102945.5a31dbe5@voom.fritz.box> From: Alexander Graf Message-ID: <56FCC99C.2030809@suse.de> Date: Thu, 31 Mar 2016 08:54:20 +0200 MIME-Version: 1.0 In-Reply-To: <20160331102945.5a31dbe5@voom.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Laurent Vivier Cc: thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 31.03.16 01:29, David Gibson wrote: > On Wed, 30 Mar 2016 19:13:00 +0200 > Laurent Vivier wrote: > >> If the processor is in little-endian mode, an alignment interrupt must >> occur for the following instructions: lmw, stmw, lswi, lswx, stswi or stswx. >> >> This is what happens with KVM, so change TCG to do the same. >> >> As the instruction can be emulated by the kernel, enable the change >> only in softmmu mode. >> >> Signed-off-by: Laurent Vivier > > I guess this makes sense given the existing hardware behaviour, even > though it seems a bit perverse to me to make the emulator strictly less > functional. > > Alex, what do you think? In general we only implement strict checks if it breaks guests not to have them. Are you aware of any such case? Alex