From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alfMo-0007y0-FR for qemu-devel@nongnu.org; Thu, 31 Mar 2016 12:22:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alfMl-0004tq-97 for qemu-devel@nongnu.org; Thu, 31 Mar 2016 12:22:42 -0400 References: <1459434536-28145-1-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <56FD4ECD.9040703@redhat.com> Date: Thu, 31 Mar 2016 10:22:37 -0600 MIME-Version: 1.0 In-Reply-To: <1459434536-28145-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GQsqmtcwx74RwdXQHKAt8IM32Eqr9Jsde" Subject: Re: [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jasowang@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GQsqmtcwx74RwdXQHKAt8IM32Eqr9Jsde Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/31/2016 08:28 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini May want to add: regression introduced in commit 96a1616. > --- > net/net.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake >=20 > diff --git a/net/net.c b/net/net.c > index 594c3b8..3847a13 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev= , Error **errp) > } > =20 > error_propagate(errp, err); > + opts_visitor_cleanup(ov); > return ret; > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GQsqmtcwx74RwdXQHKAt8IM32Eqr9Jsde Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW/U7OAAoJEKeha0olJ0NqeOIH/29OylXaMeB63nvu1fumHSNv MMRM7760K6ImgckmBc9UtLQwMeIB55f23Vf3fEBwya7q6jGnKVgHBAEeVT327sW0 5MnDjA7sRhaIsGIx6DUkuvk7PZo9jan2k3erEJhJitRkM3AmvJHqkbU8jMcTxQci ez4oF2OhzrH0/ADN+XBd58KnW4kC1RQEXYdEEvSikP65eaB1fy/2R9syIu3waFGG UTJmdpbUMqmFnnxiWTJDFFmHDlq64+WFEfsijcrrdsi8z2V32dMn3Papma2XVcEb LObetU2eeS6/aOgqzpvICMycUNLiaB4yKX15cHLr3t/EBFSazh91r3qc3Y6WxcQ= =ke+N -----END PGP SIGNATURE----- --GQsqmtcwx74RwdXQHKAt8IM32Eqr9Jsde--