From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ali3V-0003C7-Fr for qemu-devel@nongnu.org; Thu, 31 Mar 2016 15:14:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ali3Q-0000yM-WC for qemu-devel@nongnu.org; Thu, 31 Mar 2016 15:14:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ali3Q-0000yI-QL for qemu-devel@nongnu.org; Thu, 31 Mar 2016 15:14:52 -0400 References: <1459448132-52364-1-git-send-email-alex@alex.org.uk> <211A7D9C-884C-4F50-964C-22B963B9662C@alex.org.uk> From: Eric Blake Message-ID: <56FD772A.3000900@redhat.com> Date: Thu, 31 Mar 2016 13:14:50 -0600 MIME-Version: 1.0 In-Reply-To: <211A7D9C-884C-4F50-964C-22B963B9662C@alex.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Pcx3L2lEsQHdP8bAAav6V2aDVxvXjoruj" Subject: Re: [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh , Wouter Verhelst Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Pcx3L2lEsQHdP8bAAav6V2aDVxvXjoruj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/31/2016 12:21 PM, Alex Bligh wrote: >=20 > On 31 Mar 2016, at 19:15, Alex Bligh wrote: >=20 >> It is doubtful whether anyone is using NBD_CMD_FLAG_FUA >> at the moment in any case. >=20 > Drat. I spoke too soon. Qemu uses it, but presumably from its > own .h file. Yes, qemu has its own nbd.h, which still has nbd_request with a single uint32_type that holds both flags and command type. It wouldn't be too hard to rework that to more closely match upstream NBD. >=20 > However, it's now nonsensical having it defined as 1<<16 in a > 16 bit flags variable. I don't see any problem with your patch on the NBD project side of things; it's not like 'make install' is dumping a header into /usr/include for client programs to reuse (which is _why_ qemu is using its own nbd.h), because no one has really churned out an NBD-client library for embedding in larger programs. >=20 > Should we produce a new name for it (and future command flags) > that aren't shifted left 16 places, and just maintain the > current value for compatibility? I don't see the point. Your fix looks correct. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Pcx3L2lEsQHdP8bAAav6V2aDVxvXjoruj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW/XcqAAoJEKeha0olJ0Nq5bYH/1L9SoSsBzUQIGEg12DkgG5o LAKOy+GZ02nTG5HP3jqruHSdxDadW/kTqSB4C6F0iDih6Q8JTZzy4Nkhl9P6LXSb 2Qq5CCnqSl2QJZWk7m2JAG7I+DgGlj/vu7WHyT+ZxWmcdvWOGYIPxg1MFiFl0GK2 V+g6Iq03JD1s0oK8wAiN+tlxYadITa6BkwyB12p6MbDo5lPtSSF/mR7Zuh7nO8if hfKRONMDDl26WRYbFZZOKQf4X895sMKhJRXc6qy6Bn+opF/s5q9ZZWIfHirz8Kst 9LaJ8AWWPRQB/Pzf2LVoyCb7XSBb2u7hLCGtehw+OI4kX0JxifpXd4UT/vhn3Uk= =4ofw -----END PGP SIGNATURE----- --Pcx3L2lEsQHdP8bAAav6V2aDVxvXjoruj--