From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aliry-0006oi-3K for qemu-devel@nongnu.org; Thu, 31 Mar 2016 16:07:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aliru-0006YO-U1 for qemu-devel@nongnu.org; Thu, 31 Mar 2016 16:07:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aliru-0006YG-Nq for qemu-devel@nongnu.org; Thu, 31 Mar 2016 16:07:02 -0400 References: <1459448132-52364-1-git-send-email-alex@alex.org.uk> <211A7D9C-884C-4F50-964C-22B963B9662C@alex.org.uk> <56FD772A.3000900@redhat.com> <22F045FF-5560-443D-98C0-D634FC0985E1@alex.org.uk> From: Eric Blake Message-ID: <56FD8365.5020709@redhat.com> Date: Thu, 31 Mar 2016 14:07:01 -0600 MIME-Version: 1.0 In-Reply-To: <22F045FF-5560-443D-98C0-D634FC0985E1@alex.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2p7s3NtmmrLt0OFQbm5o1qjIXgWGDO79i" Subject: Re: [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: "nbd-general@lists.sourceforge.net" , Wouter Verhelst , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2p7s3NtmmrLt0OFQbm5o1qjIXgWGDO79i Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/31/2016 01:25 PM, Alex Bligh wrote: >=20 > On 31 Mar 2016, at 20:14, Eric Blake wrote: >=20 >>> >>> >>> Should we produce a new name for it (and future command flags) >>> that aren't shifted left 16 places, and just maintain the >>> current value for compatibility? >> >> I don't see the point. Your fix looks correct. >=20 > OK. And the wrongness hasn't yet got into /usr/include/linux/nbd.h Still using the older '__be32 type;' instead of the newer '__be16 flags; __be16 type;', changing that one will be ABI compatible, but not API compatible. I don't know what people want to do there, :( > or include/uapi/linux/nbd.h ; these have no reference to FUA at all, I'm not finding that file on my system; not sure what it contains, or where it is maintained. > even though it does have NBD_FLAG_SEND_FLUSH, which is odd as I added > both flags at the same time. >=20 > So I'm guessing it's safe. >=20 > -- > Alex Bligh >=20 >=20 >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2p7s3NtmmrLt0OFQbm5o1qjIXgWGDO79i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW/YNlAAoJEKeha0olJ0Nq3HIH/iLDQqeqzuGi1aRUW/54U/FV K5If6fuWkBNLcBhoQYJ6tU9V/kHHH+kLAF5FtzriRT3QHKYdLZMQxAfqya/NMb3c ip5H36VXfhk9DEqXhOiPiwZShDasslZuNwOBcFGZdDOXDy+0aRi4m0olUHl7X0U6 jtUT+/T6we5qgSX+KKwSdSAQKGmkSIwpSRpTlQmO2UKVdoTTGDRAw174SQbYMIhA l3CS8ffVjL28DbmE3JEhkQq6TKW5gnA9etO9vXDNq6AT895YLkIaBuZqjBCNudrS 3k5So8vBg7ABGee5b0P0bKcBtmeTfnMJlygPT6Tdqs1bd6owjJLQO8M85Q7V7Jo= =2HkP -----END PGP SIGNATURE----- --2p7s3NtmmrLt0OFQbm5o1qjIXgWGDO79i--