From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aloFU-0008Tc-Jv for qemu-devel@nongnu.org; Thu, 31 Mar 2016 21:51:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aloFQ-0003Sx-Jk for qemu-devel@nongnu.org; Thu, 31 Mar 2016 21:51:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aloFQ-0003St-E9 for qemu-devel@nongnu.org; Thu, 31 Mar 2016 21:51:40 -0400 References: <1458902535-9715-1-git-send-email-109lozanoi@gmail.com> <56FB7DD0.7070501@redhat.com> From: Jason Wang Message-ID: <56FDD427.7010509@redhat.com> Date: Fri, 1 Apr 2016 09:51:35 +0800 MIME-Version: 1.0 In-Reply-To: <56FB7DD0.7070501@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] util: Improved qemu_hexmap() to include an ascii dump of the buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Isaac Lozano <109lozanoi@gmail.com>, qemu-devel@nongnu.org Cc: Peter Crosthwaite , jsnow@redhat.com, kraxel@redhat.com On 03/30/2016 03:18 PM, Thomas Huth wrote: > There's a typo in the title: qemu_hexmap should be qemu_hexdump/ instead. > > On 25.03.2016 11:42, Isaac Lozano wrote: >> qemu_hexdump() in util/hexdump.c has been changed to give also include a >> ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have >> been replaced with calls to qemu_hexdump(). This takes care of two misc >> BiteSized Tasks. >> >> Signed-off-by: Isaac Lozano <109lozanoi@gmail.com> >> --- >> >> v2: Fixed code-style and made debug line smaller. >> >> net/net.c | 30 +----------------------------- >> util/hexdump.c | 33 ++++++++++++++++++++++----------- >> 2 files changed, 23 insertions(+), 40 deletions(-) > [...] > > Code looks fine now, thanks for taking care of this! > > Reviewed-by: Thomas Huth > > Jason, since there is no explicit maintainer for util/hexdump.c, could > you maybe take this through your net tree, since this patch touches > net/net.c as well? Yes, applied in -net. Thanks > > Thomas > >