From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aloL1-00022D-Mh for qemu-devel@nongnu.org; Thu, 31 Mar 2016 21:57:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aloKx-0004VJ-KX for qemu-devel@nongnu.org; Thu, 31 Mar 2016 21:57:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aloKx-0004VF-EP for qemu-devel@nongnu.org; Thu, 31 Mar 2016 21:57:23 -0400 References: <1459168451-2626-1-git-send-email-dhannawatpooja1@gmail.com> From: Jason Wang Message-ID: <56FDD57E.8010206@redhat.com> Date: Fri, 1 Apr 2016 09:57:18 +0800 MIME-Version: 1.0 In-Reply-To: <1459168451-2626-1-git-send-email-dhannawatpooja1@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5] net: Allocating Large sized arrays to heap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pooja Dhannawat , qemu-devel@nongnu.org On 03/28/2016 08:34 PM, Pooja Dhannawat wrote: > nc_sendv_compat has a huge stack usage of 69680 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Pooja Dhannawat > --- > net/net.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/net/net.c b/net/net.c > index b0c832e..663da13 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -709,23 +709,28 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size) > static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, > int iovcnt, unsigned flags) > { > - uint8_t buf[NET_BUFSIZE]; > + uint8_t *buf = NULL; > uint8_t *buffer; > size_t offset; > + ssize_t ret; > > if (iovcnt == 1) { > buffer = iov[0].iov_base; > offset = iov[0].iov_len; > } else { > + buf = g_new(uint8_t, NET_BUFSIZE); > buffer = buf; > - offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); > + offset = iov_to_buf(iov, iovcnt, 0, buf, NET_BUFSIZE); > } > > if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { > - return nc->info->receive_raw(nc, buffer, offset); > + ret = nc->info->receive_raw(nc, buffer, offset); > } else { > - return nc->info->receive(nc, buffer, offset); > + ret = nc->info->receive(nc, buffer, offset); > } > + > + g_free(buf); > + return ret; > } > > ssize_t qemu_deliver_packet_iov(NetClientState *sender, Applied to -net. Thanks