From: Jason Wang <jasowang@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
Date: Fri, 1 Apr 2016 10:00:15 +0800 [thread overview]
Message-ID: <56FDD62F.7080702@redhat.com> (raw)
In-Reply-To: <56FD4ECD.9040703@redhat.com>
On 04/01/2016 12:22 AM, Eric Blake wrote:
> On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> May want to add: regression introduced in commit 96a1616.
>
>> ---
>> net/net.c | 1 +
>> 1 file changed, 1 insertion(+)
> Reviewed-by: Eric Blake <eblake@redhat.com>
Applied to -net.
Thanks
>
>> diff --git a/net/net.c b/net/net.c
>> index 594c3b8..3847a13 100644
>> --- a/net/net.c
>> +++ b/net/net.c
>> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
>> }
>>
>> error_propagate(errp, err);
>> + opts_visitor_cleanup(ov);
>> return ret;
>> }
>>
>>
prev parent reply other threads:[~2016-04-01 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 14:28 [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak Paolo Bonzini
2016-03-31 16:22 ` Eric Blake
2016-04-01 2:00 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FDD62F.7080702@redhat.com \
--to=jasowang@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).