From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Roman Kagan" <rkagan@virtuozzo.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"KY Srinivasan" <kys@microsoft.com>,
"Andreas Färber" <afaerber@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V!
Date: Fri, 1 Apr 2016 11:36:45 +0300 [thread overview]
Message-ID: <56FE331D.6030005@openvz.org> (raw)
In-Reply-To: <1459498682-3871-1-git-send-email-pbonzini@redhat.com>
On 04/01/2016 11:18 AM, Paolo Bonzini wrote:
> Microsoft loves Linux, and Red Hat loves .NET. Since we can put whatever
> we want in the Hyper-V vendor signature, let's show some love too!
>
> Cc: Andreas Färber <afaerber@suse.de>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Denis V. Lunev <den@openvz.org>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> Cc: KY Srinivasan <kys@microsoft.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target-i386/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 799fdfa..1968f04 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -592,7 +592,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> c = &cpuid_data.entries[cpuid_i++];
> c->function = HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS;
> if (!cpu->hyperv_vendor_id) {
> - memcpy(signature, "Microsoft Hv", 12);
> + memcpy(signature, "KVM<3HyperV!", 12);
> } else {
> size_t len = strlen(cpu->hyperv_vendor_id);
>
potentially this could be dangerous. This could break
hypervisor detection code. I'll check this today and
reply.
But you have made my day. Thank you for April 1.
next prev parent reply other threads:[~2016-04-01 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 8:18 [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V! Paolo Bonzini
2016-04-01 8:36 ` Denis V. Lunev [this message]
2016-04-01 8:58 ` Daniel P. Berrange
2016-04-01 9:06 ` Paolo Bonzini
2016-04-01 10:13 ` Roman Kagan
2016-04-01 14:12 ` Michael Roth
2016-04-01 20:28 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE331D.6030005@openvz.org \
--to=den@openvz.org \
--cc=afaerber@suse.de \
--cc=alex.williamson@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kys@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).