From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1aluou-00088g-If
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 04:52:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1aluor-0001Uv-AM
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 04:52:44 -0400
Received: from mail-am1on0127.outbound.protection.outlook.com
	([157.56.112.127]:1776
	helo=emea01-am1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1aluoq-0001Tm-Oq
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 04:52:41 -0400
References: <1459498682-3871-1-git-send-email-pbonzini@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <56FE331D.6030005@openvz.org>
Date: Fri, 1 Apr 2016 11:36:45 +0300
MIME-Version: 1.0
In-Reply-To: <1459498682-3871-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V!
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Roman Kagan <rkagan@virtuozzo.com>, Alex Williamson <alex.williamson@redhat.com>, KY Srinivasan <kys@microsoft.com>, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>, Eduardo Habkost <ehabkost@redhat.com>

On 04/01/2016 11:18 AM, Paolo Bonzini wrote:
> Microsoft loves Linux, and Red Hat loves .NET.  Since we can put whatever
> we want in the Hyper-V vendor signature, let's show some love too!
>
> Cc: Andreas F=C3=A4rber <afaerber@suse.de>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Denis V. Lunev <den@openvz.org>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> Cc: KY Srinivasan <kys@microsoft.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   target-i386/kvm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 799fdfa..1968f04 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -592,7 +592,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>           c =3D &cpuid_data.entries[cpuid_i++];
>           c->function =3D HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS;
>           if (!cpu->hyperv_vendor_id) {
> -            memcpy(signature, "Microsoft Hv", 12);
> +            memcpy(signature, "KVM<3HyperV!", 12);
>           } else {
>               size_t len =3D strlen(cpu->hyperv_vendor_id);
>  =20
potentially this could be dangerous. This could break
hypervisor detection code. I'll check this today and
reply.

But you have made my day. Thank you for April 1.