From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alv1z-00027v-SE for qemu-devel@nongnu.org; Fri, 01 Apr 2016 05:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alv1w-000576-MO for qemu-devel@nongnu.org; Fri, 01 Apr 2016 05:06:15 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:32865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alv1w-000571-EX for qemu-devel@nongnu.org; Fri, 01 Apr 2016 05:06:12 -0400 Received: by mail-wm0-x244.google.com with SMTP id i204so2994226wmd.0 for ; Fri, 01 Apr 2016 02:06:12 -0700 (PDT) Sender: Paolo Bonzini References: <1459498682-3871-1-git-send-email-pbonzini@redhat.com> <20160401085803.GA8191@redhat.com> From: Paolo Bonzini Message-ID: <56FE39FF.8060302@redhat.com> Date: Fri, 1 Apr 2016 11:06:07 +0200 MIME-Version: 1.0 In-Reply-To: <20160401085803.GA8191@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V! List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Eduardo Habkost , qemu-devel@nongnu.org, Alex Williamson , Roman Kagan , "Denis V. Lunev" , KY Srinivasan , =?UTF-8?Q?Andreas_F=c3=a4rber?= On 01/04/2016 10:58, Daniel P. Berrange wrote: > On Fri, Apr 01, 2016 at 10:18:02AM +0200, Paolo Bonzini wrote: >> Microsoft loves Linux, and Red Hat loves .NET. Since we can put whatever >> we want in the Hyper-V vendor signature, let's show some love too! >> >> Cc: Andreas Färber >> Cc: Alex Williamson >> Cc: Denis V. Lunev >> Cc: Eduardo Habkost >> Cc: Roman Kagan >> Cc: KY Srinivasan >> Signed-off-by: Paolo Bonzini >> --- >> target-i386/kvm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> index 799fdfa..1968f04 100644 >> --- a/target-i386/kvm.c >> +++ b/target-i386/kvm.c >> @@ -592,7 +592,7 @@ int kvm_arch_init_vcpu(CPUState *cs) >> c = &cpuid_data.entries[cpuid_i++]; >> c->function = HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS; >> if (!cpu->hyperv_vendor_id) { >> - memcpy(signature, "Microsoft Hv", 12); >> + memcpy(signature, "KVM<3HyperV!", 12); > > I think it'd be nicer to use the unicode heart symbol ♡ encoded as utf-8 > eg > > memcpy(signature, "KVM\xe2\x99\xa1HyperV", 12); I'll try to get v2 ready in the next 13 hours and 53 minutes. Paolo