From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>, agraf@suse.de, aik@ozlabs.ru
Cc: lvivier@redhat.com, peter.maydell@linaro.org,
qemu-ppc@nongnu.org, mdroth@linux.vnet.ibm.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-ppc: Correct KVM synchronization for ppc_hash64_set_external_hpt()
Date: Fri, 1 Apr 2016 12:28:31 +0200 [thread overview]
Message-ID: <56FE4D4F.2050003@redhat.com> (raw)
In-Reply-To: <1459482767-12573-1-git-send-email-david@gibson.dropbear.id.au>
On 01/04/2016 05:52, David Gibson wrote:
> This seems like the right minimal fix in the qemu-2.6 timeframe to fix
> the actual bug. However, longer term it seems like the correct thing
> to do might be to set kvm_vcpu_dirty early in the reset path. Thoughts?
Isn't it done already? vl.c does:
pause_all_vcpus();
cpu_synchronize_all_states();
qemu_system_reset(VMRESET_REPORT);
resume_all_vcpus();
Thanks,
Paolo
> diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c
> index 72c4ab5..caf41ce 100644
> --- a/target-ppc/mmu-hash64.c
> +++ b/target-ppc/mmu-hash64.c
> @@ -283,8 +283,6 @@ void ppc_hash64_set_external_hpt(PowerPCCPU *cpu, void *hpt, int shift,
> CPUPPCState *env = &cpu->env;
> Error *local_err = NULL;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (hpt) {
> env->external_htab = hpt;
> } else {
next prev parent reply other threads:[~2016-04-01 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 3:52 [Qemu-devel] [PATCH] target-ppc: Correct KVM synchronization for ppc_hash64_set_external_hpt() David Gibson
2016-04-01 10:28 ` Paolo Bonzini [this message]
2016-04-04 1:10 ` David Gibson
2016-04-04 2:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE4D4F.2050003@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).