From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwJl-0007Jk-Hs for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:28:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alwJh-0007Lj-Im for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:28:41 -0400 References: <1459482767-12573-1-git-send-email-david@gibson.dropbear.id.au> From: Paolo Bonzini Message-ID: <56FE4D4F.2050003@redhat.com> Date: Fri, 1 Apr 2016 12:28:31 +0200 MIME-Version: 1.0 In-Reply-To: <1459482767-12573-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: Correct KVM synchronization for ppc_hash64_set_external_hpt() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, aik@ozlabs.ru Cc: lvivier@redhat.com, peter.maydell@linaro.org, qemu-ppc@nongnu.org, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org On 01/04/2016 05:52, David Gibson wrote: > This seems like the right minimal fix in the qemu-2.6 timeframe to fix > the actual bug. However, longer term it seems like the correct thing > to do might be to set kvm_vcpu_dirty early in the reset path. Thoughts? Isn't it done already? vl.c does: pause_all_vcpus(); cpu_synchronize_all_states(); qemu_system_reset(VMRESET_REPORT); resume_all_vcpus(); Thanks, Paolo > diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c > index 72c4ab5..caf41ce 100644 > --- a/target-ppc/mmu-hash64.c > +++ b/target-ppc/mmu-hash64.c > @@ -283,8 +283,6 @@ void ppc_hash64_set_external_hpt(PowerPCCPU *cpu, void *hpt, int shift, > CPUPPCState *env = &cpu->env; > Error *local_err = NULL; > > - cpu_synchronize_state(CPU(cpu)); > - > if (hpt) { > env->external_htab = hpt; > } else {