From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alwTX-00043n-Bj for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:38:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alwTU-00015G-33 for qemu-devel@nongnu.org; Fri, 01 Apr 2016 06:38:47 -0400 References: <1459413561-30745-1-git-send-email-bharata@linux.vnet.ibm.com> <1459413561-30745-6-git-send-email-bharata@linux.vnet.ibm.com> <20160401033054.GM416@voom.redhat.com> From: Paolo Bonzini Message-ID: <56FE4FA4.8090702@redhat.com> Date: Fri, 1 Apr 2016 12:38:28 +0200 MIME-Version: 1.0 In-Reply-To: <20160401033054.GM416@voom.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tb7Vn83CaL5er5R8IDfBgIv1qcc8CPBBN" Subject: Re: [Qemu-devel] [RFC PATCH v2.1 05/12] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Bharata B Rao Cc: mjrosato@linux.vnet.ibm.com, agraf@suse.de, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, imammedo@redhat.com, afaerber@suse.de, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tb7Vn83CaL5er5R8IDfBgIv1qcc8CPBBN Content-Type: multipart/mixed; boundary="NF1AoAoX7R0F3s3o17jsNWsDWVjb61cHO" From: Paolo Bonzini To: David Gibson , Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, afaerber@suse.de, imammedo@redhat.com, armbru@redhat.com, thuth@redhat.com, aik@ozlabs.ru, agraf@suse.de, ehabkost@redhat.com, pkrempa@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com, mjrosato@linux.vnet.ibm.com, borntraeger@de.ibm.com Message-ID: <56FE4FA4.8090702@redhat.com> Subject: Re: [RFC PATCH v2.1 05/12] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback References: <1459413561-30745-1-git-send-email-bharata@linux.vnet.ibm.com> <1459413561-30745-6-git-send-email-bharata@linux.vnet.ibm.com> <20160401033054.GM416@voom.redhat.com> In-Reply-To: <20160401033054.GM416@voom.redhat.com> --NF1AoAoX7R0F3s3o17jsNWsDWVjb61cHO Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 01/04/2016 05:30, David Gibson wrote: > On Thu, Mar 31, 2016 at 02:09:14PM +0530, Bharata B Rao wrote: >> From: Igor Mammedov >> >> pre_plug callback is to be called before device.realize() is executed.= >> This would allow to check/set device's properties from HotplugHandler.= >> >> Signed-off-by: Igor Mammedov >> Signed-off-by: Bharata B Rao >=20 > Reviewed-by: David Gibson >=20 > It would be really nice to get some opinion on this from Andreas or > Paolo. Certainly okay for me, Igor did all of the HotplugHandler design and work= =2E Paolo >> --- >> hw/core/hotplug.c | 11 +++++++++++ >> hw/core/qdev.c | 9 ++++++++- >> include/hw/hotplug.h | 14 +++++++++++++- >> 3 files changed, 32 insertions(+), 2 deletions(-) >> >> diff --git a/hw/core/hotplug.c b/hw/core/hotplug.c >> index 645cfca..17ac986 100644 >> --- a/hw/core/hotplug.c >> +++ b/hw/core/hotplug.c >> @@ -13,6 +13,17 @@ >> #include "hw/hotplug.h" >> #include "qemu/module.h" >> =20 >> +void hotplug_handler_pre_plug(HotplugHandler *plug_handler, >> + DeviceState *plugged_dev, >> + Error **errp) >> +{ >> + HotplugHandlerClass *hdc =3D HOTPLUG_HANDLER_GET_CLASS(plug_handl= er); >> + >> + if (hdc->pre_plug) { >> + hdc->pre_plug(plug_handler, plugged_dev, errp); >> + } >> +} >> + >> void hotplug_handler_plug(HotplugHandler *plug_handler, >> DeviceState *plugged_dev, >> Error **errp) >> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >> index db41aa1..a0b3aad 100644 >> --- a/hw/core/qdev.c >> +++ b/hw/core/qdev.c >> @@ -1062,6 +1062,14 @@ static void device_set_realized(Object *obj, bo= ol value, Error **errp) >> g_free(name); >> } >> =20 >> + hotplug_ctrl =3D qdev_get_hotplug_handler(dev); >> + if (hotplug_ctrl) { >> + hotplug_handler_pre_plug(hotplug_ctrl, dev, &local_err); >> + if (local_err !=3D NULL) { >> + goto fail; >> + } >> + } >> + >> if (dc->realize) { >> dc->realize(dev, &local_err); >> } >> @@ -1072,7 +1080,6 @@ static void device_set_realized(Object *obj, boo= l value, Error **errp) >> =20 >> DEVICE_LISTENER_CALL(realize, Forward, dev); >> =20 >> - hotplug_ctrl =3D qdev_get_hotplug_handler(dev); >> if (hotplug_ctrl) { >> hotplug_handler_plug(hotplug_ctrl, dev, &local_err); >> } >> diff --git a/include/hw/hotplug.h b/include/hw/hotplug.h >> index 2db025d..50d84e9 100644 >> --- a/include/hw/hotplug.h >> +++ b/include/hw/hotplug.h >> @@ -46,7 +46,8 @@ typedef void (*hotplug_fn)(HotplugHandler *plug_hand= ler, >> * hardware (un)plug functions. >> * >> * @parent: Opaque parent interface. >> - * @plug: plug callback. >> + * @pre_plug: pre plug callback called at start of device.realize(tru= e) >> + * @plug: plug callback called at end of device.realize(true). >> * @unplug_request: unplug request callback. >> * Used as a means to initiate device unplug for dev= ices that >> * require asynchronous unplug handling. >> @@ -59,6 +60,7 @@ typedef struct HotplugHandlerClass { >> InterfaceClass parent; >> =20 >> /* */ >> + hotplug_fn pre_plug; >> hotplug_fn plug; >> hotplug_fn unplug_request; >> hotplug_fn unplug; >> @@ -74,6 +76,16 @@ void hotplug_handler_plug(HotplugHandler *plug_hand= ler, >> Error **errp); >> =20 >> /** >> + * hotplug_handler_pre_plug: >> + * >> + * Call #HotplugHandlerClass.pre_plug callback of @plug_handler. >> + */ >> +void hotplug_handler_pre_plug(HotplugHandler *plug_handler, >> + DeviceState *plugged_dev, >> + Error **errp); >> + >> + >> +/** >> * hotplug_handler_unplug_request: >> * >> * Calls #HotplugHandlerClass.unplug_request callback of @plug_handle= r. >=20 --NF1AoAoX7R0F3s3o17jsNWsDWVjb61cHO-- --tb7Vn83CaL5er5R8IDfBgIv1qcc8CPBBN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW/k+kAAoJEL/70l94x66DuZkH/2vORliyMOXy5h1bfzuw+1T4 Wu/v/s8v7+aQDZmr4HMpzN7rO9unNPlf+SrcCxU0OeH+dRcGfU8t8G89rJdHFKtS 1o0tA0Zkq50KUJv4TnTWygASByFiLiQn0qjU7z6Bss6+sANQy9P8D/RTJaMNKnmN QDTkrA0ArAZI668sZJHu5v/zElpwUWNdvTPEkKmVMpG6/rjNStl03dPsnL0NdVLD 7O7XSi+5/uUh2nV3q5dp4+zngjqt+LGS3zVd0nnZLBxWudwcpkkYMCwE3Dp7o7s5 kNsrHiu9KJG+tfoVlIkneUOI3rVCItv26TctkSdZaqm45yo1KWaZC/ZaE1ur0X0= =562N -----END PGP SIGNATURE----- --tb7Vn83CaL5er5R8IDfBgIv1qcc8CPBBN--